Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search bar #460

Merged
merged 3 commits into from
Sep 14, 2023
Merged

fix: search bar #460

merged 3 commits into from
Sep 14, 2023

Conversation

SUNNYKUMAR1232
Copy link
Contributor

@SUNNYKUMAR1232 SUNNYKUMAR1232 commented Aug 22, 2023 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

Fixes

Description

Please describe your pull request.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@SUNNYKUMAR1232 SUNNYKUMAR1232 changed the title Fix/searchbar fix: search bar Aug 22, 2023
@120EE0692 120EE0692 self-requested a review August 23, 2023 07:50
@120EE0692 120EE0692 added the enhancement New feature or request label Aug 23, 2023
120EE0692
120EE0692 requested changes Aug 23, 2023
View reviewed changes
client/src/components/marginals/DesktopNavbar.js Outdated Show resolved Hide resolved
client/src/components/marginals/MobileNavbar.js Outdated Show resolved Hide resolved
@120EE0692
Copy link
Member

@SUNNYKUMAR1232 please complete your checklist for this pull request.

@120EE0692 120EE0692 merged commit 05e8eac into Monday-Morning:main Sep 14, 2023
120EE0692 added a commit that referenced this pull request Oct 15, 2023
@120EE0692 @Anish-Sarawgi
@dibendusahani @SUNNYKUMAR1232
feat: rebase with main (#474)
25dbd2e 
* chore: update CC info 2023 (#451)

* feat(home): increase number of displayed articles on the home page (#453)

chore(home): increase display articles

* chore: delete repo docs (#455)

* chore: delete repo docs

* chore: format html templete

* fix(home): remove duplicate article in home page (#456)

* fix(photostory): optimise the state update in photostory (#444)

* fix(photostory): optimise the state update

* fix(photostory): update right side image in carousel

* chore: update sac info page (#467)

* fix: search bar (#460)

* fix: search bar

* fix: serach bar

* fix: search bar

---------

Co-authored-by: Anish Sarawgi <98693953+Anish-Sarawgi@users.noreply.github.com>
Co-authored-by: Dibendu Sahani <112952404+dibendusahani@users.noreply.github.com>
Co-authored-by: SUNNY KUMAR <123469525+SUNNYKUMAR1232@users.noreply.github.com>
120EE0692 added a commit that referenced this pull request Oct 15, 2023
@120EE0692 @rutajdash
@Shurtu-gal @anish-patro @Anish-Sarawgi @dibendusahani @SUNNYKUMAR1232
feat: onboarding (#475)
57a6e02 
* chore: user onboarding flow (#426)

* feat: redirect to home on skip onboarding

* chore: go to interested topic page

* feat(graphql): add add user store path mutation

* feat(graphql): add user interested topic mutation

* feat(graphql): add user news letter subscription mutation

* feat: integrate mutation to selected topics

* chore: change auth state

* feat: integrate newsletter subscricption

* chore:change user flow

* chore: change to user id

* chore: add category number in interested topics

* chore: change data type

* feat: add update user profile picture

* fix: user profile image path and mid

* feat: add get firebase user

* chore: change verify email flow

* feat: webmail authentication userflow (#440)

* feat: addNITRMail mutation

* feat: imagekit config file

* chore: update onboarding placeholders

* fix: standardise user mutations

* fix: add null check for firebaseToken

* feat: sign in and sign up auth user flows

* feat: implement sign in and signup auth user flows

* chore: rectify imports for used and unused

* feat: handle migrated accounts

* fix(migrated-user): add missing field

* fix: uncomment useRouter

* feat: user onboarding experience (#441)

* feat: add loading fallback

* feat: check already registered nitr mail

* fix: restore deleted imports

* feat: add default profile picture

* refactor: auth for server and client-side with middleware checks (#447)

* feat: create auth middleware for article pages

* chore(icons): use precise imports to reduce build

* fix: use defaultValue instead of selected

* fix: no div inside p

* fix: missing key prop in home

* chore: configure dev and prod for debugger

* refactor: apollo context provider

* refactor: apollo client for server side queries

* chore: update env sample for server key

* fix(middleware): retrieve correct cookies

* refactor: consume client side graphClient context

* refactor: merge auth context and state as provider

* refactor: remove redundant files

* fix(import): wrong path for checkNITRMail

* fix(auth-context-provider): typo in graphClient

* fix(auth-context): typo in variable name

* fix(auth-context): send email link prod switch

* feat: add sign in button (#425)

* feat: add sign in button

* fix

* fixed

* feat: add signIn button in mobile view

* feat: add signin and signout feature (#461)

* feat: add sign in button

* fix

* fixed

* feat: add signIn button in mobile view

* feat: add user avatar

* feat: add signin signout

---------

Co-authored-by: anish <anishkumarpatro03@gmail.com>
Co-authored-by: G.Anish Kumar Patro <105335549+anish-patro@users.noreply.github.com>

* fix: missing pagination component (#469)

* chore: rename pagination to _pagination

* chore: rename _pagination to Pagination

* fix: gsi call after script load (#472)

* chore: remove gsi script (#473)

* feat: rebase with main (#474)

* chore: update CC info 2023 (#451)

* feat(home): increase number of displayed articles on the home page (#453)

chore(home): increase display articles

* chore: delete repo docs (#455)

* chore: delete repo docs

* chore: format html templete

* fix(home): remove duplicate article in home page (#456)

* fix(photostory): optimise the state update in photostory (#444)

* fix(photostory): optimise the state update

* fix(photostory): update right side image in carousel

* chore: update sac info page (#467)

* fix: search bar (#460)

* fix: search bar

* fix: serach bar

* fix: search bar

---------

Co-authored-by: Anish Sarawgi <98693953+Anish-Sarawgi@users.noreply.github.com>
Co-authored-by: Dibendu Sahani <112952404+dibendusahani@users.noreply.github.com>
Co-authored-by: SUNNY KUMAR <123469525+SUNNYKUMAR1232@users.noreply.github.com>

---------

Co-authored-by: Rutaj Dash <33367546+rutajdash@users.noreply.github.com>
Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>
Co-authored-by: G.Anish Kumar Patro <105335549+anish-patro@users.noreply.github.com>
Co-authored-by: anish <anishkumarpatro03@gmail.com>
Co-authored-by: Anish Sarawgi <98693953+Anish-Sarawgi@users.noreply.github.com>
Co-authored-by: Dibendu Sahani <112952404+dibendusahani@users.noreply.github.com>
Co-authored-by: SUNNY KUMAR <123469525+SUNNYKUMAR1232@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@120EE0692 120EE0692 120EE0692 approved these changes

Assignees

@SUNNYKUMAR1232 SUNNYKUMAR1232

Labels
enhancement New feature or request
Projects
Project Infinity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SUNNYKUMAR1232 @120EE0692