Develop to Main #10
Merged
Develop to Main #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use this module with my own configuration, I found myself with some needs that think can be usefull to make this module more reusable: * Storage management: added two variables to use existing base images an not always uploading a base image * base_pool_name: define an existing pool name * base_volume_name: define an existing base volume name * Local user management: when this variable is empty do not create a local_user. Changed default value to make this a default behaviour. * Test vm connection: in almost all cases users would use their default private key, that may be loaded with ssh-agent. So default behaviour seems to be null value, but allow to define a different value
Explain changed values and added variables
Add new variables and change defaults for some variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FEATURE] Define existing base image
[FEATURE] Local user is now optional
[FIX] Default values of
local_adminandssh_private_keyarenull