Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "spikedetector3PC" in KS3 #308

Closed
bruno-f-cruz opened this issue Jan 31, 2021 · 5 comments · Fixed by #595
Closed

Missing "spikedetector3PC" in KS3 #308

bruno-f-cruz opened this issue Jan 31, 2021 · 5 comments · Fixed by #595

Comments

@bruno-f-cruz
Copy link

Hi,

First of all congrats on the new release!
I am starting to sort a new dataset and I wanted to compare the output of 2.5 with the new 3.0.
Unfortunately, after trying to run KS3 I keep getting the following error:

Undefined function or variable 'spikedetector3PC'.

Error in extract_spikes (line 66)
        spikedetector3PC(Params, dataRAW, wTEMP, iC-1, dist, v2, iC2-1, dist2, wPCA); 

Any chance this was left out of the commit? I believe it is a new mexcuda function

Thanks,
B

@marius10p
Copy link
Contributor

Oops, let's find it.

@marius10p
Copy link
Contributor

Should be working now, sorry about that.

@bruno-f-cruz
Copy link
Author

Awesome it is working now!

I have encountered a few more crashes that I will list here. However, if it makes your life easier, close this issue and let me know if I should open individual issues ;)

  1. When running "template_learning",
    in the line 102: rez.W(:,t,:) = wsign * w(:,1:3);
The following error occurred converting from gpuArray to single:
Conversion to single from gpuArray is not possible. 

I got around it by using "gather()" but I am not sure if this is the intended fix =/

rez.W(:,t,:) = gather(wsign * w(:,1:3)); 
rez.U(:,t,:) = gather(wsign * u(:,1:3) * s(1:3,1:3)); 
  1. I believe there is another missing function, "check_clusters", that is called for the first time during "final_clustering()" (line 107) in the main script. At least I couldn't find it in the repo

Once again, thanks,

B

@marius10p
Copy link
Contributor

I had the wrong folders in my path, sorry. Testing it end-to-end again now (I have pushed the fix).

@bruno-f-cruz
Copy link
Author

Yep, after fixing another "gather" crash in
The following error occurred converting from gpuArray to single: Conversion to single from gpuArray is not possible. Error in final_clustering (line 118) rez.W(:,t,:) = wsign * w(:,1:3);

I can confirm that it runs until the end and I can see spikes in Phy.

Thanks a lot and sorry for the trouble ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants