Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for uint16 data? #57

Closed
jvoigts opened this issue Apr 29, 2019 · 1 comment · Fixed by #595
Closed

Adding support for uint16 data? #57

jvoigts opened this issue Apr 29, 2019 · 1 comment · Fixed by #595

Comments

@jvoigts
Copy link

jvoigts commented Apr 29, 2019

We're currently saving data in uint16 files because that's the native output from Intan chips. I assume this goes for many ADCs. Would it make sense to you guys to add an option to switch preprocessDataSub from assuming int16 to a uint16 with a (2^16)/2 offset? Looks to me like that would be a very easy addition?

We could of course patch our copy of kilosort, or (as we do now) just convert our files separately, but that seems messier than having a config flag for these cases.

@marius10p
Copy link
Contributor

Old issue, but generally speaking I am happy to take in any pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants