chore: remove finite check from LocalPlayer

[pollend]

we've mentioned in the past having a situation where the player position is placed at (0,0,0). I'm suspecting it has something to do with this logic. so for an invalid position we just return dest or a new Vector3/Quaternion. we shouldn't be just defaulting to 0,0,0. this ends up hiding a larger underlying problem where we see some odd behavior but we've written this logic in a way to hide a large problem. I rather have the game crash with a stacktrace then try poking at thing in the dark because we've written ourselves into a corner.

#4152

[jdrueckert]

I agree that we don't want to hide any bigger problem with that but maybe instead of removing null checks entirely, we could consider throwing a reasonable exception instead.

[skaldarnar]

I think not having explicit checks for the one-line methods getPosition, getRotation, and getVelocity is completely fine. The only thing we gain here is a user-readable message, but an NPE already pins it down to a single point of failure.

A similar argument holds for getViewPosition and getViewRotation. The line in which the NPE would occur indicates well enough what the issue is (at least to the devs).

We might add todo items to revisit this when we have better exception handling (soft and hard errors for crashing to menu or to desktop).