Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: remove finite check from LocalPlayer" #4788

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

jdrueckert
Copy link
Member

Reverts #4662 as it seems to have broken Multiplayer

@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. labels Jun 24, 2021
@jdrueckert jdrueckert added this to the v5.0.0 milestone Jun 24, 2021
@jdrueckert jdrueckert requested review from pollend and skaldarnar June 24, 2021 21:28
@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label Jun 24, 2021
@pollend
Copy link
Member

pollend commented Jun 25, 2021

@jdrueckert any clue about restoring the other branch so we can work out how to better have this work.

@skaldarnar
Copy link
Member

@pollend you can restore the branch of a PR via Github. There is a "Restore branch" button next to the message that the PR was merged on the PR view.
image

@skaldarnar skaldarnar merged commit 40a8c2b into develop Jun 25, 2021
@skaldarnar skaldarnar deleted the revert-4662-chore/remove-checks-LocalPlayer branch June 25, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Type: Bug Issues reporting and PRs fixing problems Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants