Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Desktop App Download Page #1149

Closed
wants to merge 1 commit into from
Closed

[WIP] Desktop App Download Page #1149

wants to merge 1 commit into from

Conversation

wbobeirne
Copy link
Contributor

Prerequisite to #557

Description

Adds a download page at /download that describes the app, and links to downloads for it. Most of the text here is just placeholder to give a sense for layout.

Changes

  • Adds a new route at /download that renders the DownloadPage component.
  • Adds a prop to TabSection hideHeader that makes it not render the header.

TODOs

  • Figure out if we're still going to offer the HTML version
  • Provide screenshots for all platforms
  • Finalize copy / what we say about it
  • Fetch version number / direct download link from Github release

Screenshots

download-page

Copy link
Contributor

@james-prado james-prado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, there are a few things I'd like to see changed though.

  • The blue gradient seems to have a weird transition effect whenever I render the page
  • Not sure if this is intentional or not, but if we're not going to show the nav, we should be putting this page on a seperate subdomain like download.mycrypto.com
  • the 'work offline' icon should be updated to something more like this to represent an 'offline' status instead of 'online'
    • wifi-off
  • Are we initially releasing this for OSX only? If not, we should provide users the option to download other platforms. Hyper has a good example of this

@wbobeirne
Copy link
Contributor Author

  • The gradient transition was intentional, but by no means has to stay. Just trying things out.
  • I also considered a separate domain, since I felt that this page really didn't "fit" in our template. It would be easy to port to a separate project.
  • Agreed, I didn't put too much thought into these info blocks, they were mostly FPO.
  • That text is dynamic. I'll need to get screenshots for all OS's, but it's detected from the browser info: https://github.com/MyCryptoHQ/MyCrypto/pull/1149/files#diff-b0b9d12848a680b1032597632b7c90b4R50

@wbobeirne
Copy link
Contributor Author

@wbobeirne wbobeirne closed this Apr 6, 2018
@dternyak dternyak deleted the download-page branch May 23, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants