Discourage Private Keys / Keystore

[dternyak]

• Disable by greying out + link to tbd Electron release page in Web based version (Wallet Decrypt)
  • Keystore
  • Mnemonic
  • raw private key
• Add MetaMask, Parity Signer with style updates as suggested in mockup below to Create Wallet View. Disable on web:
  • Keystore
  • Mnemonic

[tayvano]

We strongly encourage you to use a [hardware wallet](https://myetherwallet.github.io/knowledge-base/hardware-wallets/hardware-wallet-recommendations.html) or [MetaMask](https://myetherwallet.github.io/knowledge-base/migration/moving-from-private-key-to-metamask.html) to interact with your wallet on MyEtherWallet.com. It is safer & easier. Using your private key, mnemonic, or keystore file can result in lost funds if you visit a fake MyEtherWallet.com. [Learn how easy it is to switch today ->](https://myetherwallet.github.io/knowledge-base/migration/)"

+1 for forcing using to wait 10 seconds when decrypting (while showing a message like the above)—don't show if offline or on localhost / file

If you convert to password field, make sure there is an eye icon. We moved away from the password field because even if the very early days people seemed incapable of debugging when they had some extra characters or 0x at the beginning or something.

Unlocking existing wallets online and on phishing sites is probably 95% of phishing. It's uncommon someone generates on a phishing site as they typically read guides or tutorials. Not to say we shouldn't encourage doing it offline, just that unlocking is by far the biggest problem.

[wbobeirne]

Convert input type to password (with option to reveal/eye icon) for:

Unfortunately these are both textareas, which do not support type="password". We could make them inputs, or try to come up with a hacky way of replacing characters with dots. Let me know what's preferred, otherwise I'm just going to leave this out.

[dternyak]

@wbobeirne Any reason not to go with an input? Seems fairly straightforward.

[wbobeirne]

@dternyak after #925 is merged, do you think we should close this? Or do we want to implement any of the other notes from the original post?

[dternyak]

@wbobeirne I would like to further emphasize MetaMask as a wallet creation option, including to the point of including it in the wallet generation row.

We can disable / grey out mnemonic and keystore on web completely.

[dternyak]

@wbobeirne I've updated the issue based on our recent discussion.

[dternyak]

@wbobeirne With Electron dev builds around the corner, and the recent xss vulnerabilities, I'm removing the blocking tag so that we can focus on finally removing raw keys on the web based MyCrypto.