Wallet Decrypt Redesign #677
Conversation
wbobeirne
added
the
status: ready for review
wbobeirne
requested review from
HenryNguyen5,
dternyak,
tayvano and
skubakdj
| )} | ||
| </div> | ||
| ) : ( | ||
| <WalletDecrypt hidden={unlocked} disabledWallets={DISABLE_WALLETS.UNABLE_TO_SIGN} /> |
There was a problem hiding this comment.
@skubakdj this was my suggested change for how we use the disabledWallets prop. LMK if it looks good to you.
| transform: translate(-50%, -100%) translateY(-8px); | ||
| transition-delay: 400ms, 400ms, 300ms; | ||
| } | ||
| } |
There was a problem hiding this comment.
I felt that this was the lowest friction way to implement tooltips, instead of making the component take in a whole bunch of props for showing and hiding. You simply add this mixin to the parent element you want to show the tooltip on hover. Let me know if y'all would rather have it be component props. Maybe we can do either / or?
| @@ -82,7 +82,7 @@ | |||
| "x_Json": "Αρχείο JSON (μη κρυπτογραφημένο) ", | |||
| "x_JsonDesc": "Αυτή είναι η μη κρυπτογραφημένη, JSON μορφή του ιδιωτικού κλειδιού σας. Αυτό σημαίνει ότι δεν απαιτείται συνθηματικό όμως οποιοσδήποτε βρει το JSON σας έχει πρόσβαση στο πορτοφόλι και στον αιθέρα σας χωρίς συνθηματικό. ", | |||
| "x_Keystore": "Αρχείο Keystore (UTC / JSON · Συνιστάται · Κρυπτογραφημένο) ", | |||
| "x_Keystore2": "Αρχείο Keystore (UTC / JSON) ", | |||
| "x_Keystore2": "Αρχείο Keystore ", | |||
| "x_KeystoreDesc": "Αυτό το αρχείο Keystore έχει την ίδια μορφή που χρησιμοποιείται από το Mist ώστε να μπορείτε εύκολα να το εισάγετε στο μέλλον. Είναι το συνιστώμενο αρχείο για λήψη και δημιουργία αντιγράφου ασφαλείας. ", | |||
| "x_MetaMask": "Metamask / Mist ", | |||
There was a problem hiding this comment.
TODO: Do the same Metamask / Mist split I did in en.json to all languages.
|
Still need to review implementation, but great work from a usability perspective 👍 A few issues I found on the UI / usability side:
(Opinionated) I think vertically and horizontally centering the unlock view would be an improvement. Will be back with a code review later today 😄 |
| @@ -81,9 +81,11 @@ | |||
| "x_Json": "JSON File (unencrypted) ", | |||
| "x_JsonDesc": "This is the unencrypted, JSON format of your private key. This means you do not need the password but anyone who finds your JSON can access your wallet & Ether without the password. ", | |||
| "x_Keystore": "Keystore File (UTC / JSON · Recommended · Encrypted) ", | |||
| "x_Keystore2": "Keystore File (UTC / JSON) ", | |||
| "x_Keystore2": "Keystore File ", | |||
There was a problem hiding this comment.
Is this change OK? Or should I make x_Keystore3?
There was a problem hiding this comment.
@tayvano Feel free to chime in with your thoughts.
My understanding is we'll do a once-over for all of the copy closer to release, and can address issues at that point. We'll need to merge updated translations from V3 and create keys for all raw markup in the codebase as well.
So no big deal either way.
…tification when unlock fails.
|
While MetaMask is likely the most popular option, we may want to make users aware than any web3 provider is supported. |
I forgot to mention this up top, but it detects that metamask is installed and shows that. Also detects mist: With no known web3 client detected
With Mist
|
|
Closes #565 and addresses a few of #557's checkboxes. Rather than list all the changes I made, I think it's just best to watch it in action.
Screenshots / Gfycats
Desktop Account Unlock (Gfycat)
Mobile Account Unlock (Gfycat)
Sign & Verify
Contract Deploy
Contract Interact
Caveats