Passwordify Private Key & Mnemonic Inputs #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dternyak
reviewed
Jan 26, 2018
| @@ -17,7 +18,7 @@ interface Validated { | |||
| } | |||
|
|
|||
| function validatePkeyAndPass(pkey: string, pass: string): Validated { | |||
| const fixedPkey = stripHexPrefix(pkey); | |||
| const fixedPkey = stripHexPrefix(pkey).trim(); | |||
There was a problem hiding this comment.
perhaps the trim should happen in stripHexPrefix? A minor opinionated nitpick.
dternyak
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticks off another box from #557. Converts the private key and mnemonic phrase inputs into passwords. However, because a user may want to verify them if the input is invalid, I've added the ability to toggle them into their former textareas. Since we use this functionality in a lot of places (Generate keystore wallet, wallet info tab, recreate keystore file modal) I went ahead and made a
TogglablePasswordcomponent and converted all instances of this to use the shared component.Screenshots
Private Key (Hidden Password)
Private Key (Visible Textarea)
Mnemonic (Hidden Password)
Mnemonic (Visible Textarea)