[Parity Signer] Add future support for ERC-681 #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I got tscheck errors when trying to push, but the same errors were thrown on |
maciejhirsz
changed the title
|
If you're using npm its known to throw ts errors due to version mismatch, yarn should work fine |
dternyak
reviewed
Jun 13, 2018
| @@ -94,7 +94,7 @@ class QrSignerModal extends React.Component<Props, State> { | |||
| return; | |||
| } | |||
|
|
|||
| this.props.finalizeSignature(signature); | |||
| this.props.finalizeSignature('0x' + signature); | |||
There was a problem hiding this comment.
TODO (for myself): circle back and provide utility function for this.
There was a problem hiding this comment.
addHexPrefix does this from ethereumjs-util
There was a problem hiding this comment.
@maciejhirsz You cool with making this small tweak? No reason not to merge after imo.
dternyak
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepares the Parity Signer address scanning for the future versions that will use ERC-681 formatted strings (more context).
This change is backwards compatible, old (current) versions of Parity Signer should work without changes.
Changes
@parity/qr-signerto0.3.1onScanwill now callback with an object containingaddressandchainId, so made appropriate adjustments inParitySigner.tsx.Steps to Test
ethereum:0x5555555555555555555555555555555555555555@42(chainId is being parsed, but we throw it away right now)