Skip to content

Commit

Permalink
[BUGFIX] Enquote development tool paths for Windows (#865)
Browse files Browse the repository at this point in the history
If the path-to-executable part of a command contains Unix-style path separators
(which are supported on Windows), it must be enclosed in double quotation marks
to work on Windows.
  • Loading branch information
JakeQZ authored Apr 21, 2020
1 parent ee8c570 commit eb2a629
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).

### Fixed
- Make sure to use the Composer-installed development tools
([#862](https://github.com/MyIntervals/emogrifier/pull/862))
([#862](https://github.com/MyIntervals/emogrifier/pull/862),
[#865](https://github.com/MyIntervals/emogrifier/pull/865))
- Add missing `<head>` element when there's a `<header>` element
([#844](https://github.com/MyIntervals/emogrifier/pull/844),
[#853](https://github.com/MyIntervals/emogrifier/pull/853))
Expand Down
16 changes: 8 additions & 8 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@
},
"scripts": {
"php:version": "php -v | grep -Po 'PHP\\s++\\K(?:\\d++\\.)*+\\d++(?:-\\w++)?+'",
"php:fix": "./tools/php-cs-fixer --config=config/php-cs-fixer.php fix config/ src/ tests/",
"ci:php:lint": "vendor/bin/parallel-lint config src tests",
"ci:php:sniff": "vendor/bin/phpcs config src tests",
"ci:php:fixer": "./tools/php-cs-fixer --config=config/php-cs-fixer.php fix --dry-run -v --show-progress=dots --diff-format=udiff config/ src/ tests/",
"ci:php:md": "./tools/phpmd src text config/phpmd.xml",
"ci:php:psalm": "vendor/bin/psalm --show-info=false",
"ci:tests:unit": "vendor/bin/phpunit tests/",
"ci:tests:sof": "vendor/bin/phpunit tests/ --stop-on-failure",
"php:fix": "\"./tools/php-cs-fixer\" --config=config/php-cs-fixer.php fix config/ src/ tests/",
"ci:php:lint": "\"vendor/bin/parallel-lint\" config src tests",
"ci:php:sniff": "\"vendor/bin/phpcs\" config src tests",
"ci:php:fixer": "\"./tools/php-cs-fixer\" --config=config/php-cs-fixer.php fix --dry-run -v --show-progress=dots --diff-format=udiff config/ src/ tests/",
"ci:php:md": "\"./tools/phpmd\" src text config/phpmd.xml",
"ci:php:psalm": "\"vendor/bin/psalm\" --show-info=false",
"ci:tests:unit": "\"vendor/bin/phpunit\" tests/",
"ci:tests:sof": "\"vendor/bin/phpunit\" tests/ --stop-on-failure",
"ci:tests": [
"@ci:tests:unit"
],
Expand Down

0 comments on commit eb2a629

Please sign in to comment.