[BUGFIX] Enquote development tool paths for Windows #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the path-to-executable part of a command contains Unix-style path separators (which are supported on Windows), it must be enclosed in double quotation marks to work on Windows.
|
I'm not sure that "enquote" is a word. :-) Should it be "encode" or "quote" (or did you mash both together on purpose)? |
oliverklee
approved these changes
Apr 21, 2020
It's listed in some dictionaries, though perhaps not the most authoritative. The change could be committed with a different message if you prefer? |
Ah, thanks, I've just learned something new! :-) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the path-to-executable part of a command contains Unix-style path separators
(which are supported on Windows), it must be enclosed in double quotation marks
to work on Windows.