Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linter] Checks for empty if branches with no else branch. #16854

Closed
wants to merge 3 commits into from

Conversation

tx-tomcat
Copy link
Contributor

@tx-tomcat tx-tomcat commented Mar 25, 2024

Description

Checks for empty if branches with no accompanying else branch, suggesting potential redundancy.
Aims to improve code clarity by highlighting conditional structures that perform no action.
Encourages developers to either complete the conditional logic or remove the unnecessary if.

Run the linter

cargo test move_check_testsuit

Testing

File testing: empty_if_no_else.move

Release notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 4:37pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 4:37pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 4:37pm
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 4:37pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 4:37pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 4:37pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 4:37pm

Copy link

vercel bot commented May 31, 2024

@tx-tomcat is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this into #16874

@tnowacki tnowacki closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants