[Verifier] verify-bytecode-meter prints module/function breakdown #16963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
amnn
commented
Mar 29, 2024
| "Package will NOT pass metering check!" | ||
| }; | ||
|
|
||
| // Add overall header and footer message; |
There was a problem hiding this comment.
This was quite fiddly (very order sensitive, and lots of magic numbers). Unsure whether there's a cleaner way to do this with tabled so tips appreciated!
There was a problem hiding this comment.
I remember fiddling with it too, but I don't have any tips on top of my mind. I think in the newer version of tabled things are a bit cleaner, but there's a lot of breaking changes and did not get around updating everything.
|
|
||
| // Add overall header and footer message; | ||
| table.with(TablePanel::header(message)); | ||
| table.with(TablePanel::footer(message)); |
There was a problem hiding this comment.
Duplicating the message to deal with long outputs where the top might have scrolled off the top of the screen.
There was a problem hiding this comment.
I would say that this is even desired, having both footers and headers for long tables is useful!
7 tasks
tnowacki
reviewed
Apr 3, 2024
## Description Use a custom meter to track every function and module that is verified, and display all of them. ## Test Plan ``` deepbook$ cargo run --bin sui -p sui \ -- client verify-bytecode-meter \ --module build/DeepBook/bytecode_modules/math.mv ╭──────────────────────────────────────╮ │ Package will pass metering check! │ ├──────────────────────────────────────┤ │ Limits │ ├─────────────────────────┬────────────┤ │ packages │ 16,000,000 │ │ modules │ 16,000,000 │ │ functions │ 16,000,000 │ ├─────────────────────────┴────────────┤ │ Ticks Used │ ├─────────────────────────┬────────────┤ │ <unknown> │ 41,915 │ │ math │ 41,915 │ │ unsafe_mul │ 1,225 │ │ unsafe_mul_round │ 5,675 │ │ mul │ 2,410 │ │ mul_round │ 2,905 │ │ unsafe_div │ 1,225 │ │ unsafe_div_round │ 6,085 │ │ div_round │ 2,905 │ │ count_leading_zeros │ 19,485 │ ├─────────────────────────┴────────────┤ │ Package will pass metering check! │ ╰──────────────────────────────────────╯ ```
dariorussi
approved these changes
Apr 8, 2024
amnn
added a commit
that referenced
this pull request
Apr 8, 2024
When passing modules to `sui client verify-bytecode-meter`, support passing multiple `--modules` to be treated as a single package. ## Test Plan ``` deepbook$ cargo run --bin sui -p sui \ -- client verify-bytecode-meter \ --module build/DeepBook/bytecode_modules/math.mv \ --module build/DeepBook/bytecode_modules/clob.mv Running bytecode verifier for 2 modules ╭──────────────────────────────────────────────────╮ │ Package will pass metering check! │ ├──────────────────────────────────────────────────┤ │ Limits │ ├─────────────────────────────────────┬────────────┤ │ packages │ 16,000,000 │ │ modules │ 16,000,000 │ │ functions │ 16,000,000 │ ├─────────────────────────────────────┴────────────┤ │ Ticks Used │ ├─────────────────────────────────────┬────────────┤ │ <unknown> │ 1,859,140 │ │ math │ 41,915 │ │ unsafe_mul │ 1,225 │ │ unsafe_mul_round │ 5,675 │ │ mul │ 2,410 │ │ mul_round │ 2,905 │ │ unsafe_div │ 1,225 │ │ unsafe_div_round │ 6,085 │ │ div_round │ 2,905 │ │ count_leading_zeros │ 19,485 │ │ clob │ 1,817,225 │ │ destroy_empty_level │ 1,205 │ │ create_account │ 360 │ │ create_pool │ 480 │ │ deposit_base │ 5,490 │ │ deposit_quote │ 5,490 │ │ withdraw_base │ 6,500 │ │ withdraw_quote │ 6,500 │ │ swap_exact_base_for_quote │ 20,805 │ │ swap_exact_quote_for_base │ 18,590 │ │ match_bid_with_quote_quantity │ 383,275 │ │ match_bid │ 310,200 │ │ match_ask │ 316,500 │ │ place_market_order │ 37,615 │ │ inject_limit_order │ 70,195 │ │ place_limit_order │ 184,740 │ │ order_is_bid │ 540 │ │ emit_order_canceled │ 4,905 │ │ emit_order_filled │ 8,335 │ │ cancel_order │ 57,890 │ │ remove_order │ 20,095 │ │ cancel_all_orders │ 64,425 │ │ batch_cancel_order │ 102,405 │ │ list_open_orders │ 57,300 │ │ account_balance │ 6,620 │ │ get_market_price │ 3,265 │ │ get_level2_book_status_bid_side │ 39,785 │ │ get_level2_book_status_ask_side │ 39,785 │ │ get_level2_book_status │ 23,545 │ │ get_order_status │ 20,385 │ ├─────────────────────────────────────┴────────────┤ │ Package will pass metering check! │ ╰──────────────────────────────────────────────────╯ ``` ## Stack - #16903 - #16941 - #16945 - #16963 --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes `sui client verify-bytecode-meter` supports passing multiple `--module` flags to verify multiple compiled modules together as if they were one package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a custom meter to track every function and module that is verified, and display all of them.
Test Plan
Stack
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
sui client verify-bytecode-meterprints a breakdown of verifier cost by module and function in a package.