[Verifier] verify-bytecode-meter accepts multiple modules #16966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
@amnn the table looks great, well done fiddling with it. Maybe you should do more tables for the CLI 😄 |
amnn
force-pushed
the
amnn/verify-multi-mod
branch
from
5c376d8
to
dd6c091
Compare
amnn
force-pushed
the
amnn/verify-multi-mod
branch
from
5dc5f69
to
aca7be7
Compare
amnn
force-pushed
the
amnn/verify-multi-mod
branch
from
aca7be7
to
6dd7101
Compare
dariorussi
approved these changes
Apr 8, 2024
amnn
force-pushed
the
amnn/verify-multi-mod
branch
from
6dd7101
to
24c0b15
Compare
When passing modules to `sui client verify-bytecode-meter`, support passing multiple `--modules` to be treated as a single package. ## Test Plan ``` deepbook$ cargo run --bin sui -p sui \ -- client verify-bytecode-meter \ --module build/DeepBook/bytecode_modules/math.mv \ --module build/DeepBook/bytecode_modules/clob.mv Running bytecode verifier for 2 modules ╭──────────────────────────────────────────────────╮ │ Package will pass metering check! │ ├──────────────────────────────────────────────────┤ │ Limits │ ├─────────────────────────────────────┬────────────┤ │ packages │ 16,000,000 │ │ modules │ 16,000,000 │ │ functions │ 16,000,000 │ ├─────────────────────────────────────┴────────────┤ │ Ticks Used │ ├─────────────────────────────────────┬────────────┤ │ <unknown> │ 1,859,140 │ │ math │ 41,915 │ │ unsafe_mul │ 1,225 │ │ unsafe_mul_round │ 5,675 │ │ mul │ 2,410 │ │ mul_round │ 2,905 │ │ unsafe_div │ 1,225 │ │ unsafe_div_round │ 6,085 │ │ div_round │ 2,905 │ │ count_leading_zeros │ 19,485 │ │ clob │ 1,817,225 │ │ destroy_empty_level │ 1,205 │ │ create_account │ 360 │ │ create_pool │ 480 │ │ deposit_base │ 5,490 │ │ deposit_quote │ 5,490 │ │ withdraw_base │ 6,500 │ │ withdraw_quote │ 6,500 │ │ swap_exact_base_for_quote │ 20,805 │ │ swap_exact_quote_for_base │ 18,590 │ │ match_bid_with_quote_quantity │ 383,275 │ │ match_bid │ 310,200 │ │ match_ask │ 316,500 │ │ place_market_order │ 37,615 │ │ inject_limit_order │ 70,195 │ │ place_limit_order │ 184,740 │ │ order_is_bid │ 540 │ │ emit_order_canceled │ 4,905 │ │ emit_order_filled │ 8,335 │ │ cancel_order │ 57,890 │ │ remove_order │ 20,095 │ │ cancel_all_orders │ 64,425 │ │ batch_cancel_order │ 102,405 │ │ list_open_orders │ 57,300 │ │ account_balance │ 6,620 │ │ get_market_price │ 3,265 │ │ get_level2_book_status_bid_side │ 39,785 │ │ get_level2_book_status_ask_side │ 39,785 │ │ get_level2_book_status │ 23,545 │ │ get_order_status │ 20,385 │ ├─────────────────────────────────────┴────────────┤ │ Package will pass metering check! │ ╰──────────────────────────────────────────────────╯ ```
amnn
force-pushed
the
amnn/verify-multi-mod
branch
from
24c0b15
to
f5f7599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing modules to
sui client verify-bytecode-meter, support passing multiple--modulesto be treated as a single package.Test Plan
Stack
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
sui client verify-bytecode-metersupports passing multiple--moduleflags to verify multiple compiled modules together as if they were one package.