MythMusic: let music controls work during trackinfo popup

[twitham1]

and let another i key press show track details and let common widgets work so theme can show for example progress bar and time.

Fixes #780, fixes #781, enhances #785, #786.

Highly recommend custom trackinfo_popup of themes add progressbar and time to assist seeking since FFWD/REW work as expected in #785. This is provided here in the shipped defaults and MythCenter-wide. We also add year and track number which is nice to know when skipping to next or previous track.

The XML tweaks to time and playlisttime are for #786, done here in one place to avoid conflicts. Ideally both should be merged near the same time.

Checklist

• contribution does not duplicate one of our existing pull requests
• contribution is in a branch rebased against master
• code compiles successfully without errors
• code follows the MythTV Coding Standards
• commits are logically organised and have good commit messages
• (for this PR): adjust shipped themes to include progressbar and time in trackinfo_popup

[paul-h]

The clue is in the name trackinfo_popup it's supposed to be a popup dialog not a full screen window :) It shows extra metadata for the currently selected track not just the currently playing track so you don't want visualizers, progressbars, time etc since the track you have selected may not be playing. For example if you move focus to the tree on the select music screen and select a track then press Info (I) the popup will display the metadata for that track not the playing track!

Not sure what you are trying to achieve here maybe you would be better adding a new view or change the theme for the play music screen to show what you want?

[twitham1]

Hi Paul,

I believe you are thinking of trackdetail_popup. It shows the selected track detail like you say and this PR is not touching that window.

But trackinfo_popup is available on I only over the full screen visualizer which is available only for the playing track. What I am trying to do is be able to control the music while this is displayed. I want to hit I again to show the more detailed info you mentioned, Z to move along to the next track and so on. And especially since #785 fixes REW and FFWD, I want to see where I am located in the track, just like we have over in TV when we hit I and get a progress bar. Here is what it looks like in Mythbuntu for example:

With this patch, I can control the music while seeing its position without leaving the full screen visualizer.

And as I mentioned in #781, the manual already says this should be possible so I believe it was an accident that this was not possible.

[paul-h]

Ah you are right I was thinking of the other info popup I didn't realise you was talking about the one specific to the full screen visualiser.

I can't actually try it but in principle I have no objections this PR seems like a good idea. I did try to make most operations available through the menus for those users who don't have 100 buttons on their remote so in theory you should be able to control the player that way. Admittedly it's not as convenient than using dedicated key presses :)

[twitham1]

Speaking of the menu, if I let M pop the menu over this temporary popup, then when this info disappears in 8 seconds, exiting the menu seg faults the frontend! I assume this is because the parent window of the menu no longer exists. I can workaround that by canceling the 8 second timer to make sure the parent stays around and user can dismiss it with ESCAPE. However, the menu also fails to load the visualizer list. I cannot figure out how this is possible. So currently I suppress menu during info popup: user will need to ESCAPE out of INFO to use the menu just as before.