MythMusic: trackinfo_popup is now a true OSD over fullscreen vis #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any track or player changing keys now pops the trackinfo. Like miniplayer, hitting SELECT will "stick" the info until ESCAPE. Any other key extends the 8 second timer to dismiss.
up/down changes track while left/right seeks in the track. Also at music level 1,3 can change speed along with x/w since they are more likely to be on remotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation and completion of #779, promoting trackinfo_popup to a true OSD status that can fully control the music from fullscreen visualizer while giving feedback on the controls.
Any track or player changing keys now pops the trackinfo. Like miniplayer, hitting SELECT will "stick" the info until ESCAPE. Any other key extends the 8 second timer to dismiss. The theme's trackinfo_popup should ideally show:
The shipped themes were already adjusted to show this in #779.