Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update placement of GIF button #44

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

leereilly
Copy link
Contributor

Hi! Noticed that GIF looks a little squished in the UI. Potential fix attached for your consideration!

the-gif-that-keeps-on-giffin

@N1ck
Copy link
Owner

N1ck commented Mar 6, 2022

Thanks for that, looks much better 😍 just had a minor comment about md-gif otherwise looks great 🚀

N1ck and others added 2 commits March 17, 2022 13:24
Co-authored-by: Lee Reilly <lee@github.com>
Otherwise the `<details>` element receives the click and doesn't trigger popover.

Co-authored-by: Lee Reilly <lee@github.com>
@N1ck N1ck force-pushed the the-gif-that-keeps-on-giffin branch from 11e3d53 to 8641059 Compare March 17, 2022 00:25
@N1ck N1ck merged commit 10283a3 into N1ck:master Mar 17, 2022
@leereilly leereilly deleted the the-gif-that-keeps-on-giffin branch March 17, 2022 16:44
@leereilly
Copy link
Contributor Author

Ha ha - thanks! Just came here to make those changes, but see you beat me to it 🤘🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants