Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol type arguments shouldn't be quoted on import #1300

Closed
wants to merge 1 commit into from
Closed

Symbol type arguments shouldn't be quoted on import #1300

wants to merge 1 commit into from

Conversation

joswig
Copy link
Collaborator

@joswig joswig commented May 24, 2024

Fixes #1299

@joswig joswig requested a review from a team as a code owner May 24, 2024 16:00
duranb
duranb approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@goetzrrGit goetzrrGit mentioned this pull request May 24, 2024
Merged
@duranb
Copy link
Collaborator

duranb commented May 24, 2024

Closing in favor of #1302

@duranb duranb closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@joswig joswig

@goetzrrGit goetzrrGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phoenix SeqJSON ingest quotes symbol arguments
3 participants
@joswig @duranb @goetzrrGit