Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeqJSON Import - Symbol arguments and Immediate/Hardware Commands #1302

Merged
merged 1 commit into from
May 24, 2024
Merged

SeqJSON Import - Symbol arguments and Immediate/Hardware Commands #1302

merged 1 commit into from
May 24, 2024

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented May 24, 2024 •
edited by joswig
Loading

Closes #1299 #1300 #1301

  • Symbol arguments should not be quoted when importing from seqjson
  • fix hardware/immediate command not having newline per command on seqjson import

TESTING:
I updated the unit test to account for these bugs.

Here is a SeqJSON that test both issues

  • Upload Bananation Dictionary
  • Create Parcel with dictionary
  • Create a new sequence
  • Upload the SeqJSON
    symbol_vc_hdw_bug.json

Output should be this:

@ID "test"
@LOCALS L00UNIT L01INT

C PREPARE_LOAF L00UNIT L01INT

@HARDWARE
HDW_BLENDER_DUMP
HDW_BLENDER_DUMP # description
HDW_BLENDER_DUMP
@METADATA "Key" "Value"
HDW_BLENDER_DUMP

NOTE: You will see errors in the editor because you can't mix command types

@goetzrrGit goetzrrGit added bug Something isn't working sequencing Anything related to the sequencing domain labels May 24, 2024
@goetzrrGit goetzrrGit requested a review from a team as a code owner May 24, 2024 17:45
@goetzrrGit goetzrrGit force-pushed the bug/symbol_newline_vc_hdw_commands branch from 90b5c0a to 58465dc Compare May 24, 2024 18:16
@duranb duranb mentioned this pull request May 24, 2024
Closed
@goetzrrGit
Bug fixes:
ec8ed85 
* Symbol arguments should not be quoted when importing from seqjson
* fix hardware/immediate command not having newline per command on seqjson import
@goetzrrGit goetzrrGit force-pushed the bug/symbol_newline_vc_hdw_commands branch from 58465dc to ec8ed85 Compare May 24, 2024 20:55
duranb
duranb approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@goetzrrGit goetzrrGit merged commit aa39bca into develop May 24, 2024
5 checks passed
@goetzrrGit goetzrrGit deleted the bug/symbol_newline_vc_hdw_commands branch May 24, 2024 21:01
dandelany pushed a commit that referenced this pull request Jun 13, 2024
@goetzrrGit @dandelany
SeqJSON Import - Symbol arguments and Immediate/Hardware Commands (#1302
6a7c2c5 
)

Bug fixes:

* Symbol arguments should not be quoted when importing from seqjson
* fix hardware/immediate command not having newline per command on seqjson import
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@goetzrrGit
SeqJSON Import - Symbol arguments and Immediate/Hardware Commands (#1302
e1cf1ef 
)

Bug fixes:

* Symbol arguments should not be quoted when importing from seqjson
* fix hardware/immediate command not having newline per command on seqjson import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
bug Something isn't working sequencing Anything related to the sequencing domain
Projects
None yet
Milestone
FY24 Q3 - Phoenix Sequence Editor Part 2
Development

Successfully merging this pull request may close these issues.

Phoenix SeqJSON ingest quotes symbol arguments
2 participants
@goetzrrGit @duranb