Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout template updates to existing repos #10

Closed
jordanpadams opened this issue Aug 26, 2021 · 6 comments
Closed

Rollout template updates to existing repos #10

jordanpadams opened this issue Aug 26, 2021 · 6 comments

Comments

@jordanpadams
Copy link
Member

No description provided.

@nutjob4life
Copy link
Member

I think this is much more than a size "1" task—not because it requires a clever mind, but endurance. We have 67 repositories—say 45 of those are actual code repositories. Even 30 would be a lot to go through, one-by-one, and convert from setup.pysetup.cfg or correlate pom.xml inheritance or even just update NOTICE and SECURITY files.

@jordanpadams
Copy link
Member Author

@nutjob4life feel free to update the estimate. I was thinking it would take 1 work day to complete (~5-6 per hour), but you're probably right. Something will break and require some debugging (like when I tried to retrofit pds-deep-archive this AM and it broke and I had no idea why 😁

@nutjob4life
Copy link
Member

Thanks @jordanpadams! Made it a 5 for now. We'll see how that feels. (I'm not much of a poker player 😝)

nutjob4life added a commit to NASA-PDS/registry-dashboards that referenced this issue Sep 7, 2021
jordanpadams added a commit to NASA-PDS/registry-dashboards that referenced this issue Sep 7, 2021
nutjob4life added a commit to NASA-PDS/pds-api-pythonlib that referenced this issue Sep 7, 2021
jordanpadams added a commit to NASA-PDS/pds-api-pythonlib that referenced this issue Sep 7, 2021
@jordanpadams
Copy link
Member Author

jordanpadams commented Sep 7, 2021

@nutjob4life let's put a quick pause on this for a sec. looks like some of our repos out there do not really need to be retrofitted (e.g. some empty repo or no code has been committed yet). let's focus on the active repos, and we can retrofit the others when we get to them. this list may include repos we can't really retrofit for a specific codebase, but we can at least cleanup the READMEs.

@MJJoyce
Copy link

MJJoyce commented Sep 7, 2021

We might want to test the waters with the new Python template repo prior to pushing it out across all the existing repos. There's a non-trivial amount of changes that the new template might introduce (black is going to completely reformat existing code, flake8 linting errors, tox command changes, etc.) that might be good to test drive. I'm not suuuper familiar with the inner workings of Roundup but we'll also want it to work through the new test interfaces (especially since some of the old ones might not work).

Also, +1, not a 1. Not hard work but man will it be tedious and drawn out -_-

@jordanpadams
Copy link
Member Author

@MJJoyce copy. another reason why I prioritizing repos would be useful. we can do this as we get to a repo that will be use by our community. in the above, only 2 are python repos. the rest are Java.

That being said, did we setup a linter for Java as well?

nutjob4life added a commit to NASA-PDS/pds4-jparser that referenced this issue Sep 10, 2021
nutjob4life added a commit to NASA-PDS/pds-api-javalib that referenced this issue Sep 10, 2021
jordanpadams added a commit to NASA-PDS/pds-api-javalib that referenced this issue Sep 10, 2021
nutjob4life added a commit to NASA-PDS/registry-api-service that referenced this issue Sep 11, 2021
nutjob4life added a commit to NASA-PDS/pds-api-client that referenced this issue Sep 13, 2021
nutjob4life added a commit to NASA-PDS/pds-api that referenced this issue Sep 13, 2021
nutjob4life added a commit to NASA-PDS/nasa-pds.github.io that referenced this issue Sep 13, 2021
nutjob4life added a commit to NASA-PDS/api-search-query-lexer that referenced this issue Sep 24, 2021
nutjob4life added a commit to NASA-PDS/registry-mgr that referenced this issue Sep 24, 2021
nutjob4life added a commit to NASA-PDS/registry-common that referenced this issue Sep 24, 2021
nutjob4life added a commit to NASA-PDS/mi-label that referenced this issue Sep 25, 2021
nutjob4life added a commit to NASA-PDS/pdsen-maven-parent that referenced this issue Sep 27, 2021
jordanpadams added a commit to NASA-PDS/registry-common that referenced this issue Sep 27, 2021
jordanpadams added a commit to NASA-PDS/pdsen-maven-parent that referenced this issue Sep 27, 2021
nutjob4life added a commit to NASA-PDS/deep-archive that referenced this issue Sep 28, 2021
tloubrieu-jpl added a commit to NASA-PDS/api-search-query-lexer that referenced this issue Oct 12, 2021
nutjob4life added a commit to NASA-PDS/pds-view that referenced this issue Oct 15, 2021
nutjob4life added a commit to NASA-PDS/pds-view that referenced this issue Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants