search-after pagination and ancestry membership implementation #397
Conversation
…archAfter pagination
alexdunnjpl
requested review from
tloubrieu-jpl and
al-niessner
as code owners
|
Outstanding issues:
|
periods are converted to slashes when set
… building queries. This change is completed in later commit 4067428e and squashing is not possible
…entation GroupConstraintImpl.union()"" This reverts commit badc29b.
…ductIdentifier.isLid()
…ggregateProduct this is more-correct, and necessary to allow inheritance of RefLogicNonAggregateProduct.memberOf()
…uct in the event that the name is unrecognized. see comment for justification
these appear to be cruft
This change completes earlier commit 10a57795
…in non-util contexts
Replace remaining string PDS product ids with PdsProductIdentifier objects
Membership overhaul
alexdunnjpl
changed the title
|
Integration test still need to run. |
|
@alexdunnjpl do we know what is up with the regression tests and why they are failing? |
|
@jordanpadams yep - unrelated to this PR.
Should be a simple fix |
|
@alexdunnjpl just fixed that bug in the integration tests, but it is now failing for what looks like actual failures... https://github.com/NASA-PDS/registry-api/actions/runs/7107883089/job/19616830041 It looks like the integration tests are working on main, so I think we need to update some tests as part of this PR? |
|
In the interest of the Sprint completion tomorrow. Going to merge this change and track test fixes here: #404 |
@jordanpadams do the integration tests actually run as part of the unstable I&D action? Looks like it's just roundup and build |
|
@alexdunnjpl we probably need to update that since the branch CIVD does run the tests: https://github.com/NASA-PDS/registry-api/blob/main/.github/workflows/branch-cicd.yaml |
|
@alexdunnjpl updated the unstable build to include this as well. It will still build and tag the docker image as expected, but it will fail the tests and turn up red if the tests fail. https://github.com/NASA-PDS/registry-api/blob/main/.github/workflows/unstable-cicd.yaml |
DO NOT MERGE UPON PASSING REVIEW
This PR exists to separate out these changes from those in the
membership-overhaulbranch, in an attempt to make review less miserable.🗒️ Summary
Replaces start/limit pagination with sort/search-after.
Instead of supplying qparams like
?start=100&limit=50, pagination is accomplished with qparams like?sort=_id&search-after=lidvidOfLastDocumentOfPreviousPageBreaks membership endpoints until #386 is merged into this branch
⚙️ Test Data and/or Report
Tests outstanding - need to be modified/written to reflect new pagination paradigm.
♻️ Related Issues
Fixes #352