Replace remaining string PDS product ids with PdsProductIdentifier objects #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
requested review from
tloubrieu-jpl and
al-niessner
as code owners
alexdunnjpl
force-pushed
the
pds-identifier-oop
branch
from
acd6c79
to
61b80a0
Compare
alexdunnjpl
force-pushed
the
membership-overhaul
branch
from
d0f4fb6
to
25a2268
Compare
…in non-util contexts
alexdunnjpl
force-pushed
the
pds-identifier-oop
branch
from
61b80a0
to
449ca52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Alters outstanding interfaces to use PdsProductIdentifier objects where possible, particularly at function interfaces.
This provides additional type checking and functionality, as it's clear exactly what a product identifier is and isn't.
⚙️ Test Data and/or Report
Manually tested (pending). Will be covered by automated tests for #396 and #397
♻️ Related Issues
Code quality change - no specific issue