Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtc/develop from master 2020/07/07 #468

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 7, 2020

This PR updates dtc/develop from master, which contains:

  • updates from GSL physics merge: updates to all GSL physics, several changes to interstitial routines
  • fix for multi_gases to 32 bit compiling

Associated PRs:

NCAR/ufs-weather-model#59
NCAR/fv3atm#58
#468
NCAR/ccpp-framework#310
NCAR/GFDL_atmos_cubed_sphere#15

For regression testing information, see NCAR/ufs-weather-model#59

climbfuji and others added 30 commits December 3, 2019 15:42
…cs_timestep_for_spinup

Add capability to call radiation on physics timestep for first N time steps
… concentrations, calculate effective radii before first call of radiation
Bugfix for bit-for-bit identical restart runs
gsd/develop: update from master 2020/01/27
Thompson MP, MYNN pbl and GF convection:
1. Switch the order of calls, first MYNNrad_pre (or SGSCloud_RadPre),
then rrtmg_pre. This will add sub-grid clouds from MYNN PBL (or MYNN PBL and GF)
to QC and QI, and these updated hydrometeors will be used to compute cloud paths
and effective radii.
2. In rrtmg_pre with the use of THompson MP:
	- use Thompson's subroutines make_IceNumber and make_DropletNumber
          to compute number concentrations for subgrid clouds.
        - use calc_effectRad to compute effective radii for QC and QI
          with sub-grid clouds.
        - added option (clduni) to use the same subroutine to compute
          water paths as with the GFDL MP. For this input.nl should set
          effr_in=.true.
        - the progcld5 is used mostly to compute Xu-Randall cloud
          fraction.
3. Added *SGSCloud_* modules to replace *MYNNrad* to add all subgrid
clouds to QC and QI (from MYNN PBL and GF conv).
4. Added convective clouds qci_conv to GF scheme and SGSCloud_RadPre.
5. Computation of total cloud fraction in progcld5 is change not to
depend on shallow/deep convection. Not needed in the current version of
GSD suite.
2. Bug fix for the case when GF scheme is used without MYNN. In this case always use
Xu-Randall cloud fraction.
Ben Green and others added 19 commits June 18, 2020 14:22
…ter_20200616

Update gsd/develop from master 2020/06/16
Mods to MYNN sfc and PBL for fractional/coupled for latest gsd/develop code (based on NCAR#40)
Updates to module_SGSCloud_RadPre.F90 and .meta (from Tanya)
…elop_20200630

Update master from gsd/develop 2020/06/30
 Fixes to run the CCPP multi_gases option with 32 bit
Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's alot of changes! Approved based on testing results, and a quick-look at the code.

@climbfuji climbfuji merged commit 898db79 into NCAR:dtc/develop Jul 8, 2020
@climbfuji climbfuji deleted the update_dtc_develop_from_master_20200707 branch June 27, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants