Redundant surface variable cleanup #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/ice_interstitial
…ace_skin_temperature_over_land_interstitial
mzhangw
requested review from
climbfuji,
grantfirl,
JulieSchramm and
llpcarson
as code owners
…10813 Update redund_mzhang to main 2021/08/13
climbfuji
requested changes
Aug 13, 2021
There was a problem hiding this comment.
@mzhangw your PR is reverting Xia's recent changes. It seems that you pulled in her PR and then copied over your code. See, for example, GFS_MP_generic or gfdl_cloud_microphys or m_micro. You need to fix all of these, only your code changes should show up in the diff.
|
ok.
… On Aug 13, 2021, at 9:46 AM, Dom Heinzeller ***@***.***> wrote:
@climbfuji requested changes on this pull request.
@mzhangw <https://github.com/mzhangw> your PR is Xia's recent changes. It seems that you pulled in her PR and then copied over your code. See, for example, GFS_MP_generic or gfdl_cloud_microphys or m_micro. You need to fix all of these, only your code changes should show up in the diff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#717 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2TP3ROR4JBWDPT6L7DT4U47DANCNFSM5BUYKW2Q>.
|
|
done
… On Aug 13, 2021, at 9:46 AM, Dom Heinzeller ***@***.***> wrote:
@climbfuji requested changes on this pull request.
@mzhangw <https://github.com/mzhangw> your PR is Xia's recent changes. It seems that you pulled in her PR and then copied over your code. See, for example, GFS_MP_generic or gfdl_cloud_microphys or m_micro. You need to fix all of these, only your code changes should show up in the diff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#717 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2TP3ROR4JBWDPT6L7DT4U47DANCNFSM5BUYKW2Q>.
|
…tial_save to surface_skin_temperature_over_land_save in physics/sfc_noah_wrfv4_interstitial.meta
redund_mzhang update Dom 2021/08/16
climbfuji
approved these changes
Aug 16, 2021
SMoorthi-emc
approved these changes
Aug 16, 2021
|
It includes all redundant variables I found by far, although I believe that there are more that could be done in the future. |
grantfirl
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mzhangw can you please check the list of variables again, I think the PR actually cleans up fewer than those listed here. Thanks!
This PR cleans up the following surface variables:
surface_upwelling_longwave_flux_over_water_interstitial
surface_upwelling_longwave_flux_over_land_interstitial
surface_upwelling_longwave_flux_over_ice_interstitial
sea_ice_temperature_interstitial
surface_skin_temperature_over_water_interstitial
surface_skin_temperature_over_ice_interstitial
surface_longwave_emissivity_over_water_interstitial
surface_skin_temperature_over_land_interstitial
kinematic_surface_upward_sensible_heat_flux_over
The original fv3atm PR is: NOAA-EMC/fv3atm#366
It passed all RTs.
Associated PRs:
#717
NOAA-EMC/fv3atm#368
ufs-community/ufs-weather-model#747
For regression testing, see ufs-community/ufs-weather-model#747.