Wrapper PR for #366 (remove redundant surface variables) and #363 (send correct pointers to JEDI) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd/ice_interstitial
…ace_skin_temperature_over_land_interstitial
This was referenced Aug 13, 2021
…pper_redundant_surface_variables_and_jedi_update
…tial_save to surface_skin_temperature_over_land_save in ccpp/data/GFS_typedefs.meta
climbfuji
requested review from
SMoorthi-emc,
junwang-noaa and
DusanJovic-NOAA
SMoorthi-emc
approved these changes
Aug 16, 2021
DusanJovic-NOAA
approved these changes
Aug 16, 2021
junwang-noaa
approved these changes
Aug 17, 2021
|
ccpp-physics hash is correct (8e670b0), ready to merge |
|
@DusanJovic-NOAA @junwang-noaa ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a wrapper for #366 and #363, see these PRs for details on the code changes:
Issue(s) addressed
Fixes #370.
Testing
Code change in #363 do not affect the ufs-weather-model runs. Code changes in #366 were tested on orion.intel against the existing baseline by @mzhangw, all tests passed.
See ufs-community/ufs-weather-model#747 for final regression testing.
Dependencies
NCAR/ccpp-physics#717
#368
ufs-community/ufs-weather-model#747