Updates to send correct pointers to JEDI #363
Conversation
atmos_model.F90
Outdated
| @@ -2585,6 +2586,10 @@ subroutine setup_exportdata(rc) | |||
| end if | |||
|
|
|||
| if (isFound) then | |||
| isc_g = Atm(mygrid)%bd%isc | |||
There was a problem hiding this comment.
so the Atm(mygrid)%bd%isc and the Atm_block%isc are not same?
|
I don't believe they are, but I could be mistaken. I'll take a look and see.
-Mark
On 8/4/21 9:05 PM, Jun Wang wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In atmos_model.F90
<#363 (comment)>:
> @@ -2585,6 +2586,10 @@ subroutine setup_exportdata(rc)
end if
if (isFound) then
+ isc_g = Atm(mygrid)%bd%isc
so the Atm(mygrid)%bd%isc and the Atm_block%isc are not same?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#363 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4Q2URHPKLQSSLZQGZHXQ3T3HPXPANCNFSM5BSAEBGA>.
--
Mark A. Potts, Ph.D.
Sr. HPC Software Developer
RedLine Performance Solutions, LLC
Phone 202-744-9469
***@***.***
***@***.***
|
|
You were right, Jun. I have removed the extra copies of the indices. |
|
Not an official review but looks good, thanks @mark-a-potts |
|
Is it possible to combine this PR with another (or others)? It seems like a bit of overkill to run all the regression tests against this change, but I can do that, if it is necessary. |
That sounds reasonable, assuming that your PR does not change any of the regression test results. We can figure this out tomorrow during the code manager's meeting. Thanks! |
|
@mark-a-potts I pulled your changes into #368, which will be merged next week. We can close your PR after #368 was merged, or right away, as you prefer. |
|
If you can close it when the merge happens, that would be great. Thanks! |
…nd correct pointers to JEDI) (#368) * clean up redundant surface variables * Updates to send correct pointers to JEDI Co-authored-by: man.zhang <Man.Zhang@noaa.gov> Co-authored-by: Mark Potts <Mark.Potts@noaa.gov>
|
Merged as part of #368. |
Description
Fields being exported to JEDI included halos. This PR sends the correct pointers to JEDI.
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs