Modified 2 ugwp metadata files to fix ufs-community/ufs-weather-model… #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'fhzero reproducibility' issue NCAR#908
climbfuji
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
@mdtoy I totally agree with your offline comment that this is such an easy mistake to make. It would be good if we could indicate in one or the other way that a certain variable is a diagnostic only and not persistent/can get reset. We need to think about this more.
grantfirl
approved these changes
Nov 19, 2021
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 'fhzero reproducibility' issue #908
This PR changes the Regression Test results.