Add codeowners for files that have known Points of Contact

[SamuelTrahanNOAA]

Based on this file:

https://docs.google.com/spreadsheets/d/14y0Th_sSpCqlssEMNfSZ_Ni9wrpPqfpPY0kRG7jCZB8/edit#gid=0

Solves #810

[grantfirl]

Do we want to add "team" codeowners like WRF? https://github.com/wrf-model/WRF/blob/master/.github/CODEOWNERS

[climbfuji]

@barlage for Mike Barlage, but not sure for Cenlin

[cenlinhe]

Thanks, Mike! Yes, this (@cenlinhe) is my GitHub username

[SamuelTrahanNOAA]

I've added these.

[barlage]

@cenlinhe

…

On Fri, Dec 10, 2021 at 7:40 AM Dom Heinzeller ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In CODEOWNERS <#804 (comment)>: > + +physics/rte-rrtmgp @dustinswales @Qingfu-Liu +physics/radiation_tools.* @dustinswales @Qingfu-Liu +physics/rrtmgp_lw_rte.met* @dustinswales @Qingfu-Liu +physics/radsw_param.f @dustinswales @Qingfu-Liu +physics/rrtmgp_sw_rte.met* @dustinswales @Qingfu-Liu + +physics/radsw_datatb.* @mjiacono @Qingfu-Liu +physics/radsw_param.* @mjiacono @Qingfu-Liu +physics/radsw_main.* @mjiacono @Qingfu-Liu + +physics/rayleigh_damp.* @yangfanglin +physics/GFS_stochastics.* @pjpegion @lisa-bengtsson +physics/flake* @YihuaWu-NOAA + +# FIXME: Need github contacts for: Mike Barlage (EMC) and Cenlin He (NCAR) @barlage <https://github.com/barlage> for Mike Barlage, but not sure for Cenlin — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#804 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFAZOJDNTYA5NCH5LGCLILUQIGNRANCNFSM5JXMLIDQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[ligiabernardet]

The GitHub username for Xingren Wu is wd20xw.

[SamuelTrahanNOAA]

The GitHub username for Xingren Wu is wd20xw.

I added that to the CODEOWNERS and spreadsheet.

[climbfuji]

Question: Will the current logic add the default codeowners (you, me, ...) to all the files, in addition to the individuals listed below?

[SamuelTrahanNOAA]

Question: Will the current logic add the default codeowners (you, me, ...) to all the files, in addition to the individuals listed below?

No. Only the last matching line will receive the review request.

[SamuelTrahanNOAA]

We could create an "@NCAR/ccpp-physics-codeowners" group and put it on each line. I don't have access to do that; it has to be someone with NCAR organization admin access.

[SamuelTrahanNOAA]

Question: Will the current logic add the default codeowners (you, me, ...) to all the files, in addition to the individuals listed below?

I added them manually to each line. It's getting ugly now; we should make a group for ccpp codeowners.

[climbfuji]

Agreed. I don't think I have the rights to do that, though.

[grantfirl]

@SamuelTrahanNOAA @climbfuji Are we going to try to get this in tomorrow or wait until we have the team/group thing figured out?

[SamuelTrahanNOAA]

@SamuelTrahanNOAA @climbfuji Are we going to try to get this in tomorrow or wait until we have the team/group thing figured out?

Tomorrow. It will take a while to figure out the team/group thing. There are unexpected internal organization problems, and the people who have to resolve it are managers. Managers have higher-priority problems to deal with now, since everyone is going on vacation in a few days.