Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to feature/CODEOWNERS branch of ccpp/physics #959

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Dec 14, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Add codeowners in FV3/ccpp/physics for files that have known Points of Contact

Issue(s) addressed

NCAR/ccpp-physics#810

Testing

Some test PRs were run to ensure the CODEOWNERS functionality worked as intended via test files. Also, the points of contact were alerted to this impending change.

It is impossible for this to change the regression test results, so those tests were not run.

Dependencies

@junwang-noaa
Copy link
Collaborator

This PR will be combined with those PRs scheduled for 12/16.

@DusanJovic-NOAA DusanJovic-NOAA added the No Baseline Change No Baseline Change label Dec 15, 2021
@github-actions
Copy link

@SamuelTrahanNOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • cice NOT up to date

@junwang-noaa
Copy link
Collaborator

The code is committed in PR#931.

JianpingHuang-NOAA added a commit to JianpingHuang-NOAA/ufs-weather-model that referenced this pull request Apr 21, 2024
…ity#959)

* update aqm_ver from v7.0 to v7.0.0 and a fix for exscript for rave and some update for auto_build and auto_A1_cp_fix

* update run.ver

* change config_default.yaml back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants