Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup radiation tendencies (standard names and allocation) #34

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 1, 2020

This PR addresses issue NCAR/ccpp-physics#179. It only deals with the clean up of the standard names as described in the issue, it does not remove the LTP (extra layers for radiation) logic.

The radiation tendencies on radiation time step and radiation levels are moved from the GFS_tbd_type to the GFS_interstitial_type (reduce memory).

Associated PRs:

NCAR/ccpp-physics#422
#34
NCAR/ufs-weather-model#32

For regression testing information, see NCAR/ufs-weather-model#32.

…CAR/ccpp-physics#179; move radiation tendencies on radiation timestep and radiation levels from GFS_tbd_type to GFS_interstitial_type
Copy link

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent with physics.

@climbfuji climbfuji merged commit 59e02cc into NCAR:dtc/develop Apr 2, 2020
panll pushed a commit to panll/fv3atm that referenced this pull request Jun 4, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants