Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/develop: final PR before merging to develop or master (fractional landmask changes, support for hera.gnu) #31

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 16, 2020

This PR contains the following PRs:

Further, this PR also contains:

  • a bug fix for the recently introduced logic to reset the Thompson MP radar reflectivity calculation (but which does not change the answer for the GSD suite)
  • support for GNU compiler on hera (CCPP gmake build)

Associated PRs:

NOAA-EMC/NEMS#43
NCAR/ccpp-physics#409
#31
NCAR/ufs-weather-model#28

For regression testing info, see NCAR/ufs-weather-model#28.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@climbfuji climbfuji merged commit 8672795 into NCAR:dtc/develop Mar 17, 2020
@climbfuji climbfuji deleted the final_pr_before_merging_to_develop_or_master_20200313 branch March 17, 2020 14:08
@climbfuji climbfuji restored the final_pr_before_merging_to_develop_or_master_20200313 branch March 17, 2020 14:08
panll pushed a commit to panll/fv3atm that referenced this pull request Jun 4, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Sep 24, 2020
…_radii_cleanup

Cleanup of Thompson MP cloud effective radii calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants