Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractional landmask: Changing ice fraction definition #66

Closed
wants to merge 13 commits into from

Conversation

ShanSunNOAA
Copy link
Collaborator

PLACEHOLDER

@ShanSunNOAA ShanSunNOAA marked this pull request as ready for review February 18, 2020 16:21
@climbfuji
Copy link
Collaborator

This PR has been pulled into NCAR#31 and will be merged into NCAR's dtc/develop first, before this gets merged into develop.

@climbfuji
Copy link
Collaborator

@shansun6 can you please update the description of this PR? Thanks.

@ShanSunNOAA
Copy link
Collaborator Author

ShanSunNOAA commented Mar 16, 2020 via email

@climbfuji
Copy link
Collaborator

Hi Dom, How about this: Changing the definition of ice fraction on the FV3 grid to "ratio of ice area with respect to ocean area (instead of whole cell)". Thanks, Shan

Thanks, sounds good to me.

@climbfuji
Copy link
Collaborator

Note: this PR and/or NCAR/ccpp-physics#398 do change the answer of the NoahMP regression tests for both IPD and CCPP (but in the same way, i.e. IPD and CCPP are still bit-for-bit identical between each other). See this note:

NCAR/ufs-weather-model#28 (comment)

@climbfuji
Copy link
Collaborator

This PR does not show up as merged, because it was pulled into NCAR dtc/develop first (see NCAR/ufs-weather-model#28) and later merged back to EMC develop (see #81). Therefore, this PR was effectively merged and should be closed.

@junwang-noaa
Copy link
Collaborator

Merged to develop branch in #81 , close PR

SamuelTrahanNOAA referenced this pull request in SamuelTrahanNOAA/fv3atm Jun 13, 2022
Add diagnostic tendencies for all tracers. Move all d*3dt variables into a 4D sparse array stored as `dtend(i,k,dtidx(tracer,process))` to reduce memory usage.
jkbk2004 pushed a commit that referenced this pull request Oct 11, 2022
…he P8 physics suite) (#592)

* This is equivalent to PR66 in NCAR/fv3atm: NCAR/main PR #66 (Bugfix and optimization of prognostic closure for the P8 physics suite)
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants