master: regain bit-for-bit identical results between IPD and CCPP for coupled model runs #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update my fork with NCAR's master
…pp-physics into coupled_model_ipd_ccpp_b4b
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
grantfirl
approved these changes
Mar 25, 2020
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…uplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (NCAR#419) (NCAR#417) - Fixes a bug inGFS_diagnostics.F90 that registered several stochastic variables as diagnostic output even though th arrays are not allocated if the corresponding stochastic option is turned off - Fixes a problem that led to a "duplicate symbols" error on macOS with Intel by removing files from ccpp/CMakeLists.txt that get added automatically by CCPP - Updates the submodule pointer for ccpp-physics for the changes described in Cleanup CCPP cmake flags part 1, remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS, update README.md NCAR#773 - Contains the changes in fix the number of 2d fields nsfcprop2d NCAR#419 from @HelinWei-NOAA - Updates the submodule pointer for GFDL_atmos_cubed_sphere to include latest JEDI control changes (contributed by @mark-a-potts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides updates of the CCPP code to regain bit-for-bit identical results for coupled model runs.
The bit-for-bit match was lost over two previous commits to IPD and CCPP:
ccpp-physics:
#378
#398
fv3atm:
NOAA-EMC/fv3atm#44
NOAA-EMC/fv3atm#66 (this PR doesn't show as merged, because it was pulled into NCAR dtc/develop first and then brought back to EMC develop)
Besides the absolutely necessary changes to obtain bit-for-bit identical results between IPD and CCPP in the coupled model configuration, an attempt was made to make the code look as close as possible and to initialize variables in CCPP as in IPD (even though not strictly required) so that future comparisons will be easier. This includes removing the interstitial arrays for seaice coupling and using the regular arrays (that are part of the Coupling DDT), similar to what is done in NOAA-EMC/fv3atm#86.
This PR also contains @pjpegion's bug fixes for precipitation in the coupled model configuration (#416).
Associated PRs:
#417
NOAA-EMC/fv3atm#86
ufs-community/ufs-weather-model#91
For regression testing information, see ufs-community/ufs-weather-model#91.