Sm jan102020 #44
Merged
Sm jan102020 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cplwav2atm flag for coupling wave to atm
…into SM_oct172019
…from the suites as this is included in GFS_surface_composites_inter_run
… reading fractional grid orography file and run as no fractional grid, and minor bug fix in physics driver related to the fractional grid - FV3GFS_io.F90 is modified to use lake fraction if it exists to distinguish lake from ocean
|
Associated PRs: |
Update long names of hydrometeors to match the ccpp-physics change
climbfuji
requested changes
Jan 31, 2020
.gitmodules
Outdated
| branch = dev/emc | ||
| [submodule "ccpp/framework"] | ||
| path = ccpp/framework | ||
| url = https://github.com/NCAR/ccpp-framework | ||
| path = ccpp/framework |
There was a problem hiding this comment.
Hi Moorthi, please revert the whitespace changes in .gitmodules. Thanks!
…f 250m, changeable by user to give more generality
…i-EMC SM_Jan102020 branch
|
In working on adding a test in ufs-s2s-model using the two-way coupling that is enabled by this PR, I ended up running the regression tests from the ufs-s2s-model develop branch, but switching out FV3 to point to the branch here. None of the regression tests passed. Is this expected behavior? |
|
Yes, because of a major bug fix in interpolating fluxes from atm to ocean (
I am assuming this fix is not in the control FV3 version).
Moorthi
…On Wed, Mar 4, 2020 at 3:59 PM Jessica Meixner ***@***.***> wrote:
In working on adding a test in ufs-s2s-model using the two-way coupling
that is enabled by this PR, I ended up running the regression tests from
the ufs-s2s-model develop branch, but switching out FV3 to point to the
branch here. None of the regression tests passed. Is this expected behavior?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=ALLVRYR4T2MCBFKWNAF7QP3RF26KBA5CNFSM4KHXHK72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN2HZLQ#issuecomment-594836654>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYQVCXCBOTTAAARWPWLRF26KBANCNFSM4KHXHK7Q>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: Shrinivas.Moorthi@noaa.gov
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
Good to know! Thanks - what was the bug? |
junwang-noaa
approved these changes
Mar 5, 2020
binli2337
approved these changes
Mar 5, 2020
JessicaMeixner-NOAA
approved these changes
Mar 6, 2020
climbfuji
pushed a commit
to climbfuji/fv3atm
that referenced
this pull request
Aug 14, 2020
Add tracer sanitizer
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/fv3atm
that referenced
this pull request
Nov 17, 2023
* add GFSv16 dzmin change * Add code changes in external_ic.F90 and fv_grid_tools.F90 for dev/jcsda, dycore PR NOAA-EMC#35 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Dan Holdaway <dan.holdaway@nasa.govr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good Morning Jun,
I would like to make a pull request for my fv3atm branch SM_Jan2020. This branch includes new suite definition files under ccpp/suites that can be used to run RAS, MG3, SHOC. I have submitted a pull request to CCPP to pull my ccpp/physics branch.
I addition, my branch includes updates to the physics driver (both IPD and CCPP) for wave coupling to the atmosphere. There are some other minor bug fixes. I also added the ability to read and use lake fraction in the orography data to identify lakes and ocean.
The code has been run as a 4 component coupled model as well as uncoupled for up to 60 days at C384 with RAS-MG3/SHOC combination. there are no changes to other physics; so I assume they all should work.
Thanks
Moorthi
#44
NCAR/ccpp-physics #378
ufs-weahter-model #72