NoahMP unary operator bug fix 2 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPE: bug fix SOURCE: Patricia Balle (HPE), internal DESCRIPTION OF CHANGES: Problem: Several _more_ occurrences of `a * -b` were caught by the Cray compiler. Solution: As before, the standard requires parentheses: `a * (-b)`. LIST OF MODIFIED FILES: modified: module_sf_noahmplsm.F
davegill
pushed a commit
to wrf-model/WRF
that referenced
this pull request
Feb 3, 2022
TYPE: bug fix KEYWORDS: unary operator, Noahmp SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Found more occurrences of `a* -b` in Noahmp. A space is in between `*` and `-1`. OK even for Cray, but it is still non-standard. Solution: The same solution is applied: add parentheses: `a * (-b)`. ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#33 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. More code is fixed. 2. Jenkins tests are all passing.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: unary operator, Noahmp SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Found more occurrences of `a* -b` in Noahmp. A space is in between `*` and `-1`. OK even for Cray, but it is still non-standard. Solution: The same solution is applied: add parentheses: `a * (-b)`. ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#33 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. More code is fixed. 2. Jenkins tests are all passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
SOURCE: Patricia Balle (HPE), internal
DESCRIPTION OF CHANGES:
Problem:
Several more occurrences of
a * -bwere caught by the Cray compiler.Solution:
As before, the standard requires parentheses:
a * (-b).LIST OF MODIFIED FILES:
modified: module_sf_noahmplsm.F