Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing space #2

Closed
wants to merge 15 commits into from
Closed

testing space #2

wants to merge 15 commits into from

Conversation

vikramjakhr
Copy link

Use this template to give a detailed message describing the change you want to make to the code.
If you are unclear on what should be written here, see https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message for more guidance

The title of this pull request should be a brief "purpose" for this change.

--- Delete this line and those above before hitting "Create pull request" ---

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: approximately 3 to 6 words (more is always better) related to your commit, separated by commas

SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member

DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes.

ISSUE: For use when this PR closes an issue. For issue number 123

Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED: Explicitly state if a WTF and or other tests were run, or are pending. For more complicated changes please be explicit!

RELEASE NOTE: Optional, as appropriate. Delete if not used. Included only once for new features requiring several merge cycles. Changes to default behavior are also note worthy.

@vikramjakhr vikramjakhr force-pushed the staging-release-v4.0.3 branch from 280dca9 to 677fa2e Compare October 21, 2020 15:23
hstone-scala added a commit that referenced this pull request Jan 26, 2021
vlakshmanan-scala pushed a commit that referenced this pull request Apr 4, 2024
TYPE: bug fix

KEYWORDS: unary operator, Noahmp

SOURCE: Internal

DESCRIPTION OF CHANGES:
Problem:
Found more occurrences of `a* -b` in Noahmp. A space is in between `*` and `-1`. OK even for Cray, but it is still non-standard.

Solution:
The same solution is applied: add parentheses: `a * (-b)`.

ASSOCIATED REPOSITORY CHANGE:
NCAR/noahmp#33

LIST OF MODIFIED FILES:
modified: phys/noahmp

TESTS CONDUCTED: 
1. More code is fixed.
2. Jenkins tests are all passing.
@vlakshmanan-scala vlakshmanan-scala deleted the staging-release-v4.0.3 branch April 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants