Support places search in viewfinder view #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianguerin
changed the base branch from
develop
to
feature-1796-places-autocomplete
ianguerin
force-pushed
the
feature-1796-pr-5
branch
10 times, most recently
from
eb91c94
to
32976fc
Compare
yvonnesjy
reviewed
Mar 8, 2024
ianguerin
force-pushed
the
feature-1796-pr-5
branch
5 times, most recently
from
2d61c2f
to
1d77fc0
Compare
yvonnesjy
approved these changes
Mar 12, 2024
ianguerin
force-pushed
the
feature-1796-pr-5
branch
3 times, most recently
from
9cc3209
to
af4565c
Compare
|
I'll note that I still want to use Yvonne's shared search input view as soon as that PR is merged. So I'll likely leave this in draft for a little while longer |
ianguerin
force-pushed
the
feature-1796-pr-5
branch
3 times, most recently
from
c1fcbc0
to
5a04c97
Compare
ianguerin
force-pushed
the
feature-1796-places-autocomplete
branch
from
0b1ff8c
to
92f7005
Compare
ianguerin
force-pushed
the
feature-1796-pr-5
branch
3 times, most recently
from
5afa6b4
to
73018e3
Compare
ianguerin
force-pushed
the
feature-1796-pr-5
branch
2 times, most recently
from
cca7631
to
ca12a42
Compare
Replace lat,long-only search with search for reqular query strings. fixes NCEAS#2280 fixes NCEAS#2270 fixes NCEAS#1796
ianguerin
force-pushed
the
feature-1796-pr-5
branch
from
ca12a42
to
476f5d9
Compare
ianguerin
merged commit 29735d5
into
NCEAS:feature-1796-places-autocomplete
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2280
fixes #2270
fixes #1796