-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng9 strictTemplates issues #5171
Comments
plz follow #4994 |
Note that this is still an issue with version |
cc @hsuanxyz |
Hi, @dylanvdmerwe
fix via #5265;
need to specify the reference name to narrowing types. <app-test-wrapper [control]="selector">
<nz-select ngModel="lucy" #selector="ngModel">
~~~~~~~
</nz-select>
</app-test-wrapper> |
Thank you for this! |
Reproduction link
https://github.com/dylanvdmerwe/zorro-strictTemplates-repo
Steps to reproduce
In Angular 9, set
strictTemplates
to true inangularCompilerOptions
in tsconfig.json. Runng build
on the repo.Disabling
strictTemplates
allows the code to run as expected.The repo attached is just an example of what we have run into. I am sure there are additional components and cases that would need to be checked as well.
Some additional comments here: #4757
Background info: https://auth0.com/blog/angular-9s-best-hidden-feature-strict-template-checking/
What is expected?
Ng-Zorro should not prevent the additional checks implemented by
strictTemplates
.What is actually happening?
Typing errors prevent the code from compiling.
The text was updated successfully, but these errors were encountered: