Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type errors with strictTemplates #5265

Merged
merged 1 commit into from
May 13, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5171

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 13, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #5265 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5265   +/-   ##
=======================================
  Coverage   91.32%   91.33%           
=======================================
  Files         551      551           
  Lines       13908    13908           
  Branches     2099     2099           
=======================================
+ Hits        12702    12703    +1     
  Misses        713      713           
+ Partials      493      492    -1     
Impacted Files Coverage Δ
components/calendar/calendar.component.ts 100.00% <ø> (ø)
components/cascader/typings.ts 100.00% <ø> (ø)
...onents/descriptions/descriptions-item.component.ts 100.00% <ø> (ø)
components/cascader/cascader.component.ts 95.42% <100.00%> (ø)
components/core/util/convert.ts 85.71% <100.00%> (ø)
components/date-picker/date-picker.component.ts 96.52% <100.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts 90.65% <100.00%> (ø)
components/date-picker/inner-popup.component.ts 89.83% <100.00%> (ø)
...omponents/date-picker/lib/abstract-panel-header.ts 88.63% <100.00%> (ø)
components/date-picker/lib/abstract-table.ts 89.28% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c57866...af6a170. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz force-pushed the fix/strictTemplates branch from 7973965 to af6a170 Compare May 13, 2020 11:27
@@ -18,14 +16,14 @@ declare const monaco: any;
]
})
export class NzDemoCodeEditorFullControlComponent {
editor?: editor.ICodeEditor;
editor?: editor.ICodeEditor | editor.IEditor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该看一下 IDiffEditor,我之后来处理一下

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my part

@wenqi73 wenqi73 merged commit 2982766 into NG-ZORRO:master May 13, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants