-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type errors with strictTemplates #5265
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5265 +/- ##
=======================================
Coverage 91.32% 91.33%
=======================================
Files 551 551
Lines 13908 13908
Branches 2099 2099
=======================================
+ Hits 12702 12703 +1
Misses 713 713
+ Partials 493 492 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7973965
to
af6a170
Compare
@@ -18,14 +16,14 @@ declare const monaco: any; | |||
] | |||
}) | |||
export class NzDemoCodeEditorFullControlComponent { | |||
editor?: editor.ICodeEditor; | |||
editor?: editor.ICodeEditor | editor.IEditor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该看一下 IDiffEditor,我之后来处理一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on my part
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5171
What is the new behavior?
Does this PR introduce a breaking change?
Other information