Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: more strict tsconfig options #660

Closed
trotyl opened this issue Dec 2, 2017 · 2 comments
Closed

build: more strict tsconfig options #660

trotyl opened this issue Dec 2, 2017 · 2 comments
Assignees
@trotyl
Labels
🖨 Build 💪 Enhancement

Comments

@trotyl
Copy link
Contributor

trotyl commented Dec 2, 2017

What problem does this feature solve?

Enable all tsconfig strict-ness options including:

  • alwaysStrict
  • forceConsistentCasingInFileNames
  • noFallthroughCasesInSwitch
  • noImplicitAny
  • noImplicitReturns
  • noImplicitThis
  • noUnusedLocals
  • noUnusedParameters
  • strictFunctionTypes
  • strictNullChecks

Some of them are covered by strict master option.

What does the proposed API look like?

N/A.
@trotyl trotyl self-assigned this Dec 2, 2017
@IvanX42
Copy link

IvanX42 commented Jan 3, 2018

@trotyl does it mean for now, I cant use those options above?
what my case is, i am developing my project using "strict: true" in tsconfig.json.
before installed ng-zorro-antd, it can pass "ng build --prod",
but after, it raised
ERROR in node_modules\ng-zorro-antd\antd.d.ts.NzTabSetComponent.html(28,9): : Object is possibly 'null'.
I spent hours for resolving this error including "exclude" and "skipLibCheck", but not works
so does the strict options cant work for now???
thank you !

@vthinkxie vthinkxie mentioned this issue Sep 19, 2018
Merged
3 tasks
Merott added a commit to Merott/ng-zorro-antd that referenced this issue Nov 28, 2018
@Merott
build: fix some TS build issues in templates
131cc37 
Fixes _some_ of the issues found when ng-zorro is used in projects with TS strict mode, mostly in HTML templates.

Partially addresses NG-ZORRO#660, but still a long way to go.
@Merott Merott mentioned this issue Nov 28, 2018
Closed
3 tasks
Merott added a commit to Merott/ng-zorro-antd that referenced this issue Dec 2, 2018
@Merott
build: fix some TS build issues in templates
696a6c4 
Fixes _some_ of the issues found when ng-zorro is used in projects with TS strict mode, mostly in HTML templates.

Partially addresses NG-ZORRO#660, but still a long way to go.
Merott added a commit to Merott/ng-zorro-antd that referenced this issue Dec 13, 2018
@Merott
build: fix some TS build issues in templates
e594472 
Fixes _some_ of the issues found when ng-zorro is used in projects with TS strict mode, mostly in HTML templates.

Partially addresses NG-ZORRO#660, but still a long way to go.
Merott added a commit to Merott/ng-zorro-antd that referenced this issue Dec 28, 2018
@Merott
build: fix some TS build issues in templates
156b876 
Fixes _some_ of the issues found when ng-zorro is used in projects with TS strict mode, mostly in HTML templates.

Partially addresses NG-ZORRO#660, but still a long way to go.
@vthinkxie
Copy link
Member

track #2884 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trotyl trotyl

Labels
🖨 Build 💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vthinkxie @trotyl @IvanX42