Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support more strict tslint #2165

Merged
merged 1 commit into from
Oct 6, 2018
Merged

build: support more strict tslint #2165

merged 1 commit into from
Oct 6, 2018

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #660

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vthinkxie vthinkxie changed the title feat: support more strict tslint build: support more strict tslint Sep 19, 2018
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2165 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2165   +/-   ##
======================================
  Coverage      96%     96%           
======================================
  Files         479     479           
  Lines       11697   11697           
  Branches     1564    1564           
======================================
  Hits        11230   11230           
  Misses        132     132           
  Partials      335     335
Impacted Files Coverage Δ
...ts/time-picker/nz-time-value-accessor.directive.ts 92.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ff576...2ae3d4d. Read the comment docs.

@wilsoncook wilsoncook merged commit e1b8761 into NG-ZORRO:master Oct 6, 2018
@wilsoncook wilsoncook deleted the tslint-strict branch October 6, 2018 04:55
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants