Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:*): support for Angular ivy #3740

Closed
wants to merge 10 commits into from
Closed

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jul 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3667

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 5, 2019

Deploy preview for ng-zorro-master ready!

Built with commit cd46760

https://deploy-preview-3740--ng-zorro-master.netlify.com

@lppedd
Copy link
Contributor

lppedd commented Aug 14, 2019

Seems date-fns isn't compatible with NGCC, and it's a direct dependency. What a pity.

@lppedd
Copy link
Contributor

lppedd commented Aug 20, 2019

@hsuanxyz So, I was able to compile date-fns using a custom ngcc.config.js file.

However there is still a problem with deep imports (angular/angular#32097).
The next next.3 version will include a fix (https://github.com/zefoy/ngx-swiper-wrapper/issues/226#issuecomment-522680379) and maybe I'll finally be able to compile my project, even without ng-zorro explicitly targeting Ivy.

@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #3740 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3740      +/-   ##
==========================================
- Coverage   92.42%   92.34%   -0.09%     
==========================================
  Files         506      506              
  Lines       10749    10752       +3     
  Branches     1942     1954      +12     
==========================================
- Hits         9935     9929       -6     
- Misses        400      405       +5     
- Partials      414      418       +4
Impacted Files Coverage Δ
...nts/core/no-animation/nz-no-animation.directive.ts 71.42% <ø> (ø) ⬆️
components/tree/nz-tree.component.ts 97.77% <100%> (+0.03%) ⬆️
components/popover/nz-popover.component.ts 100% <100%> (ø) ⬆️
components/pagination/nz-pagination.component.ts 98.68% <100%> (+0.03%) ⬆️
components/tooltip/nz-tooltip.component.ts 100% <100%> (ø) ⬆️
...mponents/tooltip/base/nz-tooltip-base.component.ts 94.44% <100%> (ø) ⬆️
components/time-picker/nz-time-picker.component.ts 91.78% <100%> (+1.65%) ⬆️
components/slider/nz-slider.component.ts 91.87% <100%> (+0.04%) ⬆️
components/slider/nz-slider-handle.component.ts 95.45% <100%> (+0.1%) ⬆️
components/affix/nz-affix.component.ts 96.61% <100%> (+0.02%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5f452...cd46760. Read the comment docs.

@lppedd
Copy link
Contributor

lppedd commented Aug 30, 2019

next.4 introduces a fix to avoid scanning non-Angular dependencies for entry points.
The ngcc.config.js is no more needed.
angular/angular#32303

@hsuanxyz
Copy link
Member Author

close via #4453

@hsuanxyz hsuanxyz closed this Nov 22, 2019
@hsuanxyz hsuanxyz deleted the ivy branch August 5, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants