Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to angular 9.0.0-rc.3 with ivy #4453

Merged
merged 6 commits into from
Nov 22, 2019
Merged

chore: update to angular 9.0.0-rc.3 with ivy #4453

merged 6 commits into from
Nov 22, 2019

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented Nov 20, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@auto-assign auto-assign bot requested a review from simplejason November 20, 2019 11:23
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #4453 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4453      +/-   ##
==========================================
- Coverage   92.22%   91.99%   -0.23%     
==========================================
  Files         522      518       -4     
  Lines       11107    11014      -93     
  Branches     2018     2005      -13     
==========================================
- Hits        10243    10132     -111     
- Misses        436      452      +16     
- Partials      428      430       +2
Impacted Files Coverage Δ
components/dropdown/nz-dropdown.module.ts 100% <ø> (ø) ⬆️
components/anchor/nz-anchor-link.component.ts 95.45% <ø> (ø) ⬆️
components/core/config/config.service.ts 100% <ø> (ø) ⬆️
...mponents/input-number/nz-input-number.component.ts 97.09% <ø> (ø) ⬆️
components/select/nz-option-container.component.ts 88.88% <100%> (ø) ⬆️
components/date-picker/picker.component.ts 97.4% <100%> (+0.03%) ⬆️
components/core/testing/event-objects.ts 88.88% <100%> (-0.4%) ⬇️
components/radio/nz-radio-button.component.ts 83.33% <0%> (-16.67%) ⬇️
components/date-picker/nz-week-picker.component.ts 83.33% <0%> (-16.67%) ⬇️
components/menu/nz-menu.directive.ts 91.83% <0%> (-4.09%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fed076...df789ed. Read the comment docs.

@netlify
Copy link

netlify bot commented Nov 21, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit df789ed

https://deploy-preview-4453--ng-zorro-master.netlify.com

@vthinkxie
Copy link
Member Author

angular/angular#33881

@vercel vercel bot requested a deployment to staging November 21, 2019 12:37 Abandoned
@vercel
Copy link

vercel bot commented Nov 21, 2019

Deployment failed with the following error:

An unexpected error occurred!

@vercel vercel bot requested a deployment to staging November 21, 2019 12:41 Abandoned
@vercel
Copy link

vercel bot commented Nov 21, 2019

Deployment failed with the following error:

An unexpected error occurred!

@vthinkxie vthinkxie changed the title chore: update to angular 9 with ivy chore: update to angular 9.0.0-rc.3 with ivy Nov 22, 2019
@vthinkxie vthinkxie merged commit 8f74cb7 into NG-ZORRO:master Nov 22, 2019
@wzhudev wzhudev mentioned this pull request Nov 22, 2019
Closed
This was referenced Nov 22, 2019
Closed
Closed
@hsuanxyz hsuanxyz added the 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes label Nov 22, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
chore: update to angular 9.0.0-rc.3 with ivy (NG-ZORRO#4453)
e514dbb 
* chore: update to angular 9 with ivy

* test(module:*): fix tests (#1)

* ci: add now.json

* fix: fix test error

* fix(module:date-picker): add markforcheck when animation is done (#2)

* fix(module: tree): fix tests for 9.0 version (#3)
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
chore: update to angular 9.0.0-rc.3 with ivy (NG-ZORRO#4453)
a1d39e2 
* chore: update to angular 9 with ivy

* test(module:*): fix tests (#1)

* ci: add now.json

* fix: fix test error

* fix(module:date-picker): add markforcheck when animation is done (#2)

* fix(module: tree): fix tests for 9.0 version (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simplejason simplejason Awaiting requested review from simplejason simplejason is a code owner

Assignees

@wzhudev wzhudev

Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vthinkxie @wzhudev @hsuanxyz @wenqi73 @simplejason