chore(module:message,notification): refactor #4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4723 +/- ##
==========================================
+ Coverage 92.93% 92.96% +0.02%
==========================================
Files 505 511 +6
Lines 12718 13027 +309
Branches 1963 1971 +8
==========================================
+ Hits 11819 12110 +291
- Misses 474 484 +10
- Partials 425 433 +8
Continue to review full report at Codecov.
|
wzhudev
force-pushed
the
msg-noti-9.0
branch
from
818ef65 to
ecd1be4
Compare
hsuanxyz
requested changes
Feb 19, 2020
| private eraseTimingStart: number; | ||
| private eraseTTL: number; // Time to live. | ||
|
|
||
| constructor(private _messageContainer: NzMessageContainerComponent, protected cdr: ChangeDetectorRef) {} |
There was a problem hiding this comment.
Suggested change
| constructor(private _messageContainer: NzMessageContainerComponent, protected cdr: ChangeDetectorRef) {} | |
| constructor(private messageContainer: NzMessageContainerComponent, protected cdr: ChangeDetectorRef) {} |
| this.nzConfigService | ||
| .getConfigChangeEventForComponent(NZ_CONFIG_COMPONENT_NAME) | ||
| .subscribe(() => this.updateConfig()); | ||
| this.nzConfigService.getConfigChangeEventForComponent(NZ_CONFIG_COMPONENT_NAME).subscribe(() => this.updateConfig()); |
| @@ -32,7 +32,20 @@ const NZ_NOTIFICATION_DEFAULT_CONFIG: Required<NotificationConfig> = { | |||
| selector: 'nz-notification-container', | |||
| exportAs: 'nzNotificationContainer', | |||
| preserveWhitespaces: false, | |||
| templateUrl: './nz-notification-container.component.html' | |||
| template: ` | |||
| <div class="ant-notification ant-notification-topLeft" [style.top]="top" [style.left]="'0px'"> | |||
There was a problem hiding this comment.
这里是否需要判断对应方向的 length，不然外层容器始终存在。
wzhudev
force-pushed
the
msg-noti-9.0
branch
3 times, most recently
from
4eebbec to
6045d99
Compare
added 2 commits
March 11, 2020 00:26
close NG-ZORRO#4338 chore(module:message,notification): refactor
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:notification): support opening at different places close NG-ZORRO#4338 chore(module:message,notification): refactor * chore: test with cdr * chore: remove console
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:notification): support opening at different places close NG-ZORRO#4338 chore(module:message,notification): refactor * chore: test with cdr * chore: remove console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information