Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDEPS to include the latest changes from ESCOMP/CDEPS #45

Merged
merged 37 commits into from
Apr 29, 2022

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    5179e2c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Configuration menu
    Copy the full SHA
    593566d View commit details
    Browse the repository at this point in the history
  2. correct compensating error

    jedwards4b committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    4f99c9f View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Fix buildlib when called as a subprocess

    The argument order differs for the cdeps library vs. the individual
    components. Thus, we need a different function to parse the command line
    for the library. The new parse_command_line function is a direct copy of
    the same function from buildlib.csm_share.
    
    To handle this difference in command-line arguments in the two
    situations, I have renamed the old file to buildlib_comps (which is
    identical to the old buildlib); the individual data model components now
    point to that file, leaving buildlib just being used for the cdeps
    shared library.
    
    In a following commit I will remove unnecessary code from each of these
    files.
    
    Resolves ESCOMP#104
    billsacks committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    df64cf5 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Remove unneeded code from buildlib and buildlib_comps

    It turns out that, for the most part, each line of code was just needed
    for one of these, not both. So, now that the unnecessary code is removed
    from each, there is essentially no duplication between buildlib and
    buildlib_comps.
    billsacks committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    0b43083 View commit details
    Browse the repository at this point in the history
  2. Fix typo in PR template

    billsacks committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    a0867b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Configuration menu
    Copy the full SHA
    70009ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37aff69 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. allow mapalgo of none

    adrifoster committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    5334add View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45e24e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Merge pull request ESCOMP#138 from adrifoster/allow_none_mapalgo

    Allow none mapalgo. For single-point runs of CTSM, we need to be able to set `foo:mapalgo=none` , where `foo` is the stream name.  `none` as an option to `cime_config/stream_cdeps.py`
    mvertens authored Dec 16, 2021
    Configuration menu
    Copy the full SHA
    fe4c788 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Configuration menu
    Copy the full SHA
    e71ed67 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Merge pull request ESCOMP#140 from uturuncoglu/hotfix/multi_stream

    Fix for ESMF config file for multiple stream
    mvertens authored Jan 4, 2022
    Configuration menu
    Copy the full SHA
    4ebc156 View commit details
    Browse the repository at this point in the history
  2. new comments for adding multiple lines in user_nl_xxx_stream files

    Mariana Vertenstein committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7e704ba View commit details
    Browse the repository at this point in the history
  3. changed master to main

    Mariana Vertenstein committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7fb5483 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. simplified PR template

    Mariana Vertenstein committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    151a09f View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Configuration menu
    Copy the full SHA
    11a48c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39f79b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. needed for nag.cmake

    jedwards4b committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    62b3483 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ESCOMP#142 from jedwards4b/add_srcroot_to_cmake_flags

    Description of changes
    
    Add SRCROOT to cmake flags - this is needed for nag.cmake
    jedwards4b authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    31ba51f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Configuration menu
    Copy the full SHA
    ca78692 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. fail over to v1

    jedwards4b committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    1709407 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Configuration menu
    Copy the full SHA
    1359a52 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Configuration menu
    Copy the full SHA
    38e20af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a26c64 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08795b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge pull request ESCOMP#141 from mvertens/feature/new_comments

    Description of changes
    
    Changed all references from master_task to main_task and from masterproc to mainproc
    Specific notes
    
    Also added comments to each user_nl_xxx_streams to describe how to add user changes across multiple lines. Also simplified future PR templates.
    
    Contributors other than yourself, if any: None
    
    CDEPS Issues Fixed: None
    
    Are there dependencies on other component PRs: No
    
    Are changes expected to change answers? No
    
    Any User Interface Changes (namelist or namelist defaults changes)? No
    
    Testing performed: (e.g. aux_cdeps, cesm_prealpha, etc)
    Ran cesm prealpha tests using cesm2_3_beta07 and compared answers relative to cesm2_3_alpha07d
    
    Hashes used for testing:
    cesm2_3_beta07 plus this branch
    jedwards4b authored Mar 9, 2022
    Configuration menu
    Copy the full SHA
    757c131 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0da67ff View commit details
    Browse the repository at this point in the history
  3. Merge pull request ESCOMP#145 from jedwards4b/neon_v2update

    Description of changes
    
    Updates download path for NEON data, the new path is a virtual address so in the future the
    actual location of the server can be updated without further changes here.
    Specific notes
    
    Contributors other than yourself, if any:
    
    CDEPS Issues Fixed (include github issue #):
    
    Are there dependencies on other component PRs
    
    CIME (list) 479181641
    
        CMEPS (list)
    
    Are changes expected to change answers?
    
    bit for bit
    different at roundoff level
    
        more substantial
    
    Any User Interface Changes (namelist or namelist defaults changes)?
    
    Yes
    
        No
    
    Testing performed: Hand tested NEON cases.
    
    (required) aux_cdeps
    
        machines and compilers:
        details (e.g. failed tests):
    
        (optional) CESM prealpha test
            machines and compilers
            details (e.g. failed tests):
    
    Hashes used for testing:
    
    CIME
    
        repository to check out: ESCOMP/CESM.git
        branch:
        hash:
    
    CMEPS
    
        repository to check out: ESCOMP/CESM.git
        branch:
        hash:
    
        CESM
            repository to check out: ESCOMP/CESM.git
            branch:
            hash:
    jedwards4b authored Mar 9, 2022
    Configuration menu
    Copy the full SHA
    db41b40 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Revert "Merge pull request ESCOMP#123 from jedwards4b/jedwards/solar_…

    …zenith_angle_correction"
    
    This reverts commit 39f79b4, reversing
    changes made to 4ebc156.
    billsacks committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    bae31f4 View commit details
    Browse the repository at this point in the history
  2. change NONE to None

    jedwards4b committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    d8bc453 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd94318 View commit details
    Browse the repository at this point in the history
  4. Merge pull request ESCOMP#147 from jedwards4b/neon_v2update

    Change NONE to None.
    jedwards4b authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    471e459 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Configuration menu
    Copy the full SHA
    dc77f4d View commit details
    Browse the repository at this point in the history
  2. Merge pull request ESCOMP#148 from billsacks/backout_123

    Revert PR ESCOMP#123
    
    ### Description of changes
    
    PR ESCOMP#123 (solar zenith angle correction) led to exact restart failures in some situations: see ESCOMP#144. This PR backs out the changes from ESCOMP#123 .
    
    ### Specific notes
    
    Contributors other than yourself, if any:
    
    CDEPS Issues Fixed (include github issue #): Temporarily deals with ESCOMP#144.
    
    Are there dependencies on other component PRs (if so list): no
    
    Are changes expected to change answers (bfb, different to roundoff, more substantial): more substantial. I have verified that this brings answers back to being bfb with those in cdeps0.12.35 (i.e., prior to ESCOMP#123) via a run of the aux_clm test suite.
    
    Any User Interface Changes (namelist or namelist defaults changes): no
    
    Testing performed (e.g. aux_cdeps, CESM prealpha, etc): aux_clm
    
    Hashes used for testing: billsacks/ctsm@3fd7f6fbf
    billsacks authored Mar 16, 2022
    Configuration menu
    Copy the full SHA
    2ee28ac View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Configuration menu
    Copy the full SHA
    4eb7f24 View commit details
    Browse the repository at this point in the history
  2. update datm/atm_comp_nuopc.F90

    update datm/datm_datamode_gfs_mod.F90
    binli2337 committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    7e2dc6c View commit details
    Browse the repository at this point in the history