Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5deg Marine 3DVar ctest using j-job #232

Closed
5 tasks done
guillaumevernieres opened this issue Dec 5, 2022 · 1 comment · Fixed by #234
Closed
5 tasks done

5deg Marine 3DVar ctest using j-job #232

guillaumevernieres opened this issue Dec 5, 2022 · 1 comment · Fixed by #234
Assignees
@guillaumevernieres
Milestone
godas, December 2022

Comments

@guillaumevernieres
Copy link
Contributor

guillaumevernieres commented Dec 5, 2022 •
edited
Loading

Same as #229 but for ocean and sea-ice.

Remaining issues, notes to self:

  • yaml file passed to exp setup py script is still hard-coded ... do a sed or something
    - [ ] Fixing this: line 41: setpdy.sh: command not found would make the test shell script a bit cleaner
  • Add a config.base hard-coded to the testing needs somewhere
  • Analysis output link not created for some reason ...
    - [ ] fms io, not sure I care at this point
  • copy backgrounds from comrot to rundir

Not really needed yet:

  • minor updates to the g-w to be pushed as a pr <-- Not needed unless you run in containers
@guillaumevernieres
Copy link
Contributor Author

guillaumevernieres commented Dec 7, 2022 •
edited
Loading

Remaining issues, notes to self:

  • yaml file passed to exp setup py script is still hard-coded ... do a sed or something
  • Fixing this: line 41: setpdy.sh: command not found would make the test shell script a bit cleaner
  • Add a config.base hard-coded to the testing needs somewhere
  • Analysis output link not created for some reason ...
  • fms io, not sure I care at this point
  • minor updates to the g-w to be pushed as a pr

This was referenced Dec 7, 2022
Merged
Merged
WalterKolczynski-NOAA pushed a commit to NOAA-EMC/global-workflow that referenced this issue Dec 13, 2022
@guillaumevernieres
Fix some bugs and make other changes so ctest in GDASApp works (#1172)
3e53e06 
Fix some bugs and make other changes so ctest in GDASApp works.

`$CDATE` is used instead of `$cyc` for the time being, since `cyc` isn't defined before that point in the scripts.

Fix some lines where multiple arguments were enclosed in quotation marks when they should be separate.

Update `config.ocnanal` to template out some variables and add them to the defaults yaml.

Fixes #1164 
Fixes #1173
Companion PR to [GDASApp/PR234](NOAA-EMC/GDASApp#234)
See also [GDASApp/232](NOAA-EMC/GDASApp#232)
@guillaumevernieres guillaumevernieres self-assigned this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillaumevernieres guillaumevernieres

Labels
None yet
Projects
None yet
Milestone
godas, December 2022
Development

Successfully merging a pull request may close this issue.

Testing of the Marine DA jjobs NOAA-EMC/GDASApp
1 participant
@guillaumevernieres