Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miss-placed " " in marine jjob ... #1173

Closed
guillaumevernieres opened this issue Dec 12, 2022 · 0 comments · Fixed by #1172
Closed

Miss-placed " " in marine jjob ... #1173

guillaumevernieres opened this issue Dec 12, 2022 · 0 comments · Fixed by #1172
Assignees
@guillaumevernieres

Comments

@guillaumevernieres
Copy link
Contributor

Welcome to the club @aerorahul (introduced in #1149), looks like I tought you well :) :

global-workflow/jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP

Line 45 in 5a748ee

. "${HOMEgfs}/env/${machine}.env ocnanalprep"

Miss-placing quotes is a sign of greatness, I decided.

Same issue in run.
Can't wait to turn on ctests ... A few more hours? days?
@guillaumevernieres guillaumevernieres self-assigned this Dec 12, 2022
@guillaumevernieres guillaumevernieres mentioned this issue Dec 12, 2022
Merged
11 tasks
WalterKolczynski-NOAA pushed a commit that referenced this issue Dec 13, 2022
@guillaumevernieres
Fix some bugs and make other changes so ctest in GDASApp works (#1172)
3e53e06 
Fix some bugs and make other changes so ctest in GDASApp works.

`$CDATE` is used instead of `$cyc` for the time being, since `cyc` isn't defined before that point in the scripts.

Fix some lines where multiple arguments were enclosed in quotation marks when they should be separate.

Update `config.ocnanal` to template out some variables and add them to the defaults yaml.

Fixes #1164 
Fixes #1173
Companion PR to [GDASApp/PR234](NOAA-EMC/GDASApp#234)
See also [GDASApp/232](NOAA-EMC/GDASApp#232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillaumevernieres guillaumevernieres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some bugs and make other changes so ctest in GDASApp works guillaumevernieres/global-workflow
1 participant
@guillaumevernieres