Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a positive-definite advection option #36

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

XiaqiongZhou-NOAA
Copy link
Collaborator

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Sep 14, 2020

Add a new positive-definite advection option (HORD=-5) developed by S-J Lin;
Remove other negative HORD options such as HORD=-6, HORD=-8.

Related PR
ufs-community/ufs-weather-model#215
NOAA-EMC/fv3atm#185

@climbfuji
Copy link

Is this part of the effort to merge the NOAA-EMC dev/emc version back into the NOAA-GFDL dev/emc version ?

@XiaqiongZhou-NOAA
Copy link
Collaborator Author

XiaqiongZhou-NOAA commented Sep 14, 2020 via email

Copy link
Collaborator

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Glad to see you have removed the old schemes.

Please note that all of the new and revised schemes (1–7) were implemented by S-J Lin.

@junwang-noaa junwang-noaa self-requested a review October 19, 2020 13:58
@DusanJovic-NOAA DusanJovic-NOAA merged commit 7752840 into NOAA-EMC:dev/emc Oct 19, 2020
aerorahul pushed a commit that referenced this pull request Jul 17, 2021
pull latest master updates (PR #35) into dev/gfdl
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA deleted the pd-5 branch March 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants